Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With enhanced short options enabled,
--name -abcurrently expands-abbefore it can be consumed as the value of--name. It changes the value to-aand enables-b. The same preprocessing changes literal arguments after--and options belonging to a later subcommand.Keep normalization inside the active argument context: preserve the next token of a known value-taking option, and stop at the existing terminator, subcommand boundary, or first positional argument when reordering is disabled. Existing registered numeric short aliases, boolean groups and attached-value forms keep working.
The regression tests exercise the public parser at both enhancement levels, with reordering enabled and disabled. They cover values, positional tails, numeric aliases, and unknown/mixed groups. I also verified the built CLI with pipes and real terminal input/output.
Validation on macOS arm64 with Go 1.26.0:
go vet ./...,go build ./..., andgo mod tidy -diffpass. The full suites include the native terminal tests.NO_COLOR=1makes the existingTestVerbosefail on both the base and patch. Running with that variable unset passes the full suite.The Linux/Go version matrix still needs CI.