fix: allow zero viewport height with string row heights - #12
Merged
fastfrwrd merged 1 commit intoSep 22, 2026
Merged
Conversation
fastfrwrd
requested review from
adela-almasan,
gelicia and
leeoniya
and removed request for
a team
September 21, 2026 22:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the fix from https://github.com/grafana/react-data-grid-patches/pull/2 into this fork. String row heights now accept a zero viewport height instead of throwing, using
gridHeight ?? 0for the total row height.Unlike the source repository, this branch initializes dimensions to 1. The crash still occurs when layout measures a zero-height viewport, such as a hidden grid. The regression test mounts an
auto-height grid in a zero-height viewport, then resizes it and verifies that rows still render.Based on #7 (
chore/sync-comcast-upstream), which introduces the required string row-height support;maindoes not have it yet. Merge this into that branch before #7, or retarget tomainafter #7 merges. No generated distribution patch is needed in this source repository.Validation:
multi column sort,sortPriority defined using both contexts, andsortPriority defined using both contexts and renderers.