Repository navigation
test(issuance): port RewardsManager eligibility and reclaim tests to Foundry - #1384
Merged
Maikol merged 1 commit intoOct 29, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/contracts-removal-phase-0 #1384 +/- ##
===================================================================
- Coverage 82.74% 82.33% -0.42%
===================================================================
Files 81 81
Lines 5326 5326
Branches 1132 1132
===================================================================
- Hits 4407 4385 -22
- Misses 897 919 +22
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Maikol
force-pushed
the
test/contracts-removal-t5d-rewards-eligibility
branch
from
October 29, 2026 17:34
7409b4e to
fdf08d8
Compare
Maikol
force-pushed
the
test/contracts-removal-t5c-rewards-issuers
branch
from
October 29, 2026 17:34
732f9fc to
9e18ee9
Compare
Maikol
force-pushed
the
test/contracts-removal-t5d-rewards-eligibility
branch
from
October 29, 2026 18:42
fdf08d8 to
49871d3
Compare
Maikol
force-pushed
the
test/contracts-removal-t5c-rewards-issuers
branch
2 times, most recently
from
October 29, 2026 18:48
1577e43 to
4b4f6e2
Compare
Maikol
force-pushed
the
test/contracts-removal-t5d-rewards-eligibility
branch
from
October 29, 2026 18:48
49871d3 to
53bf33e
Compare
Maikol
force-pushed
the
test/contracts-removal-t5d-rewards-eligibility
branch
from
October 29, 2026 20:07
53bf33e to
b75038d
Compare
Maikol
force-pushed
the
test/contracts-removal-t5c-rewards-issuers
branch
from
October 29, 2026 20:07
4b4f6e2 to
7dbe58a
Compare
Maikol
changed the base branch from
test/contracts-removal-t5c-rewards-issuers
to
chore/contracts-removal-phase-0
October 29, 2026 20:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the RewardsManager tests for the rewards eligibility oracle and for reclaiming denied rewards to Foundry on the issuance test base, and deletes the TypeScript tests they replace. One old precedence test was titled as a reclaim but asserted that the rewards are dropped; it is ported by what it asserts, which is what the contract does. Stacked on #1383.