Skip to content

test(issuance): port RewardsManager eligibility and reclaim tests to Foundry - #1384

Merged
Maikol merged 1 commit into
chore/contracts-removal-phase-0from
test/contracts-removal-t5d-rewards-eligibility
Oct 29, 2026
Merged

Maikol merged 1 commit into
chore/contracts-removal-phase-0from
test/contracts-removal-t5d-rewards-eligibility

Conversation

@Maikol

@Maikol Maikol commented Oct 26, 2026

Copy link
Copy Markdown
Member

Ports the RewardsManager tests for the rewards eligibility oracle and for reclaiming denied rewards to Foundry on the issuance test base, and deletes the TypeScript tests they replace. One old precedence test was titled as a reclaim but asserted that the rewards are dropped; it is ported by what it asserts, which is what the contract does. Stacked on #1383.

@codecov

codecov Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.33%. Comparing base (7dbe58a) to head (b75038d).
⚠️ Report is 1 commits behind head on chore/contracts-removal-phase-0.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           chore/contracts-removal-phase-0    #1384      +/-   ##
===================================================================
- Coverage                            82.74%   82.33%   -0.42%     
===================================================================
  Files                                   81       81              
  Lines                                 5326     5326              
  Branches                              1132     1132              
===================================================================
- Hits                                  4407     4385      -22     
- Misses                                 897      919      +22     
  Partials                                22       22              
Flag Coverage Δ
unittests 82.33% <ø> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Maikol
Maikol force-pushed the test/contracts-removal-t5d-rewards-eligibility branch from 7409b4e to fdf08d8 Compare October 29, 2026 17:34
@Maikol
Maikol force-pushed the test/contracts-removal-t5c-rewards-issuers branch from 732f9fc to 9e18ee9 Compare October 29, 2026 17:34
@Maikol
Maikol force-pushed the test/contracts-removal-t5d-rewards-eligibility branch from fdf08d8 to 49871d3 Compare October 29, 2026 18:42
@Maikol
Maikol force-pushed the test/contracts-removal-t5c-rewards-issuers branch 2 times, most recently from 1577e43 to 4b4f6e2 Compare October 29, 2026 18:48
@Maikol
Maikol force-pushed the test/contracts-removal-t5d-rewards-eligibility branch from 49871d3 to 53bf33e Compare October 29, 2026 18:48
@Maikol
Maikol force-pushed the test/contracts-removal-t5d-rewards-eligibility branch from 53bf33e to b75038d Compare October 29, 2026 20:07
@Maikol
Maikol force-pushed the test/contracts-removal-t5c-rewards-issuers branch from 4b4f6e2 to 7dbe58a Compare October 29, 2026 20:07
@Maikol
Maikol changed the base branch from test/contracts-removal-t5c-rewards-issuers to chore/contracts-removal-phase-0 October 29, 2026 20:20
@Maikol
Maikol merged commit b75038d into chore/contracts-removal-phase-0 Oct 29, 2026
6 checks passed
@Maikol
Maikol deleted the test/contracts-removal-t5d-rewards-eligibility branch October 29, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant