Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## test/contracts-removal-t5e-rewards-accounting #1386 +/- ##
=================================================================================
- Coverage 82.29% 81.41% -0.89%
=================================================================================
Files 81 81
Lines 5326 5326
Branches 1132 973 -159
=================================================================================
- Hits 4383 4336 -47
- Misses 921 968 +47
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Maikol
force-pushed
the
test/contracts-removal-t5f-rewards-legacy
branch
from
October 29, 2026 17:34
5647056 to
e6d0b16
Compare
Maikol
force-pushed
the
test/contracts-removal-t5e-rewards-accounting
branch
from
October 29, 2026 17:34
3a7004e to
6d153d6
Compare
Maikol
force-pushed
the
test/contracts-removal-t5f-rewards-legacy
branch
from
October 29, 2026 18:42
e6d0b16 to
82c840f
Compare
Maikol
force-pushed
the
test/contracts-removal-t5e-rewards-accounting
branch
from
October 29, 2026 18:42
6d153d6 to
0f62cdd
Compare
Maikol
force-pushed
the
test/contracts-removal-t5f-rewards-legacy
branch
from
October 29, 2026 18:48
82c840f to
767612b
Compare
Maikol
force-pushed
the
test/contracts-removal-t5e-rewards-accounting
branch
from
October 29, 2026 18:48
0f62cdd to
337ed2b
Compare
Port the unique cases of rewards.test.ts to legacySuite.t.sol, map the duplicates to the existing tests and delete the TS file. Move the shared deny, oracle, reclaim and accrue helpers into shared.t.sol.
Maikol
force-pushed
the
test/contracts-removal-t5f-rewards-legacy
branch
from
October 29, 2026 20:07
767612b to
8a429cd
Compare
Maikol
force-pushed
the
test/contracts-removal-t5e-rewards-accounting
branch
from
October 29, 2026 20:07
337ed2b to
168bc53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the cases from the old
rewards.test.tsthat no earlier port covers to Foundry, and deletes the file. That closes the RewardsManager test migration. Each of its 42 cases was checked by assertion against the tests already ported, and 6 had assertions not covered elsewhere. Helpers duplicated across the RewardsManager test files now live in the shared base. Also removes a dead interface and stale comments in the earlier ports, found when reviewing the whole Phase T stack. Stacked on #1385.