Repository navigation
fix(telemetry): preserve long query durations - #1226
Open
chriswessels wants to merge 1 commit into
Open
chriswessels wants to merge 1 commit into
chriswessels wants to merge 1 commit into
Conversation
chriswessels
marked this pull request as ready for review
October 29, 2026 13:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query durations are cast to
u16milliseconds before reporting, so a 70-second request is reported as 4,464 ms and sends misleading latency feedback to selection.Retain milliseconds as
u32, matching the existing protobuf fields, and use checked, saturating conversions at the wire and selection-library integer limits. A 70-second request is reported as 70,000 ms; the selection library'su16input saturates at 65,535 ms. Tests cover boundary values, client/indexer protobuf round trips, and actual selection-feedback messages. No protobuf schema or tag changes are required.Validation (on this independent branch):
cargo +nightly-2026-06-11 fmt --all -- --checkcargo +1.95.0 clippy --all-targets --all-features -- -Dwarnings --force-warn deprecated --force-warn dead-codecargo +1.95.0 test