feat: number with scale error messages#362
Merged
Merged
Conversation
Contributor
|
Preview is ready. |
Contributor
|
Playwright Test Component is ready. |
NasgulNexus
reviewed
Jun 3, 2026
| }; | ||
|
|
||
| /** | ||
| * Scales value given in defaultFactor to scaleFactor |
Contributor
There was a problem hiding this comment.
Let's delete all such comments.
| getArrayValidator, | ||
| getBooleanValidator, | ||
| getNumberValidator, | ||
| getNumberWithScaleValidator, |
Contributor
There was a problem hiding this comment.
| const baseSpec: StringSpec = { | ||
| type: SpecTypes.String, | ||
| validator: 'number', | ||
| validator: 'number_with_scale', |
Contributor
There was a problem hiding this comment.
Add a maximum and minimum so the user can immediately see the validator's work.
| format?: 'float' | 'int64'; | ||
| } | ||
|
|
||
| export const getNumberWithScaleValidator = (params: GetNumberWithScaleValidatorParams = {}) => { |
Contributor
There was a problem hiding this comment.
Let's write a couple of tests for the validation function.
NasgulNexus
approved these changes
Jun 5, 2026
Rioskill
force-pushed
the
number-with-scale-validation
branch
from
8144941 to
f660037
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added validation errors regarding scale