Skip to content

fix!: stabilize query compositions and generalize editor presets - #85

Open
SimbiozizV wants to merge 9 commits into
mainfrom
refactor_big
Open

SimbiozizV wants to merge 9 commits into
mainfrom
refactor_big

Conversation

@SimbiozizV

@SimbiozizV SimbiozizV commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fix query composition behavior: HistoryFilter keeps a complete editable draft, Dashboard forwards focus/blur callbacks, and NavigationDetail recovers when its selected tab disappears. Align all four built-in engine descriptors with Monaco presets and demonstrate them in QueryPage, including completion, cluster context, reference navigation and cleanup. Fix the ClickHouse tokenizer's zero-width match exposed by browser coverage.

Centralize public contracts in src/types, split ParameterValue and QueryGraph into internal renderers, and remove duplicated attachment updates. Complete chart/count localization, add a shared EN/RU Storybook control, remove fixture exports incorrectly indexed as stories, and add interactive regression scenarios.

Use neutral Builtin names for the optional engine UI configurations. QueriesKit displays application-supplied data and emits callbacks; it does not fetch data or execute queries. Update README and guides accordingly, including an example combining an application engine with built-in descriptions. Retain source attribution for adapted graph icons.

Commit structure

  1. Public type contracts and exports.
  2. Composition state, callbacks and attachment lifecycle fixes.
  3. Monaco engine presets and QueryPage integration.
  4. Parameter and graph renderer decomposition.
  5. Localization, Storybook coverage and documentation.
  6. Built-in engine API names, entrypoints and tests.
  7. UI-only scope and neutral documentation.

API changes

  • SPYT and YT QL descriptors use spyt and ytql instead of s-expression and yql_ansi.
  • Use createBuiltinQueryEngines, the five Builtin-prefixed types and widgets/QueryEditor/presets/builtin. Former branded names and both preset paths are removed without compatibility aliases. Other package entrypoints remain unchanged.
  • Public types are available from the root and corresponding unit entrypoints; old internal type paths are not preserved.

There are currently no external consumers. See MIGRATION.md for the resulting contracts.

Validation

  • TypeScript passed for source, Storybook and browser fixtures.
  • Full npm test passed; graph/layout tests also passed during the initial audit changes.
  • All 19 Playwright browser tests passed, including four engine presets and independent QueryPage workspaces.
  • Library build, Storybook build and tree-shaking checks passed, including public preset exports and custom-engine composition typing.
  • ESLint: 0 errors, 43 existing warnings.
  • The initial audit changes were visually checked in EN/RU, light/dark and narrow layouts, including filter Apply/Reset and dynamic navigation tabs.
  • Final repository search finds the former brand only in the graph icon source attribution; no old file paths or documentation mentions remain.

No release or deployment is requested by this PR.

@gravity-ui-bot

Copy link
Copy Markdown
Contributor

Preview is ready.

@SimbiozizV SimbiozizV changed the title fix!: align editor presets and stabilize query compositions fix!: stabilize query compositions and generalize editor presets Oct 14, 2026
Declare generated runtime dependencies, add public unit entrypoints, and validate isolated ESM/CJS consumer bundles.

BREAKING CHANGE: only query languages and JSON are registered automatically; applications must register additional Monaco languages explicitly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants