Repository navigation
fix!: stabilize query compositions and generalize editor presets - #85
Open
SimbiozizV wants to merge 9 commits into
Open
SimbiozizV wants to merge 9 commits into
SimbiozizV wants to merge 9 commits into
Conversation
Contributor
|
Preview is ready. |
Declare generated runtime dependencies, add public unit entrypoints, and validate isolated ESM/CJS consumer bundles. BREAKING CHANGE: only query languages and JSON are registered automatically; applications must register additional Monaco languages explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix query composition behavior: HistoryFilter keeps a complete editable draft, Dashboard forwards focus/blur callbacks, and NavigationDetail recovers when its selected tab disappears. Align all four built-in engine descriptors with Monaco presets and demonstrate them in QueryPage, including completion, cluster context, reference navigation and cleanup. Fix the ClickHouse tokenizer's zero-width match exposed by browser coverage.
Centralize public contracts in
src/types, split ParameterValue and QueryGraph into internal renderers, and remove duplicated attachment updates. Complete chart/count localization, add a shared EN/RU Storybook control, remove fixture exports incorrectly indexed as stories, and add interactive regression scenarios.Use neutral
Builtinnames for the optional engine UI configurations. QueriesKit displays application-supplied data and emits callbacks; it does not fetch data or execute queries. Update README and guides accordingly, including an example combining an application engine with built-in descriptions. Retain source attribution for adapted graph icons.Commit structure
API changes
spytandytqlinstead ofs-expressionandyql_ansi.createBuiltinQueryEngines, the fiveBuiltin-prefixed types andwidgets/QueryEditor/presets/builtin. Former branded names and both preset paths are removed without compatibility aliases. Other package entrypoints remain unchanged.There are currently no external consumers. See
MIGRATION.mdfor the resulting contracts.Validation
npm testpassed; graph/layout tests also passed during the initial audit changes.No release or deployment is requested by this PR.