Repository navigation
Conversation
…euse on forms-update
…s-update warnings
…nd skipped response
…s_active on feeds-update
…n on forms-create
…and confirmation deletes
…lished-page confirmations
…s and layout rows
…field id warnings
… state, and the speed check
ChrisMKindred
requested changes
Oct 28, 2026
ChrisMKindred
left a comment
ChrisMKindred
left a comment
There was a problem hiding this comment.
This looks to be in line with gravityforms#4045, and skill validation passes. I have one comment: clarify that creation warnings should be resolved by updating the saved entry, not by retrying creation and creating a duplicate.
|
|
||
| **Entry metadata for API entries:** `source_url` is empty, because the entry has no embedding page; `ip` and `user_agent` describe the API caller. | ||
|
|
||
| **Imports:** `entries-create` accepts `date_created` as a UTC timestamp (`YYYY-MM-DD HH:MM:SS`, or `YYYY-MM-DD`); without it the entry is stamped now. `entries-update` always sets `date_updated` to now. Both return a `warnings` array when a key names a field or input id that is not on the form; those values are not saved, so fix the ids and retry. |
There was a problem hiding this comment.
Could we clarify “fix the ids and retry” here? entries-create has already saved the entry when it returns warnings, so retrying creates a duplicate. Callers should instead use entries-update with the returned entry_id and corrected field IDs.
… replacement on forms-update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: https://github.com/gravityforms/backlog/issues/8313
Documents the contract changes from gravityforms/gravityforms#4045, one commit per change. Changelog section 1.1.3 lists each one.
Main additions to
SKILL.md:warningsarray.feeds-createstarts feeds paused unlessis_activeis true.feeds-updateacceptsis_activealone.forms-createadds the default admin notification whennotificationsis omitted.notifications-deleteandconfirmations-deleterequire the id asconfirmation.forms-updatemerges unsent field properties by id.forms-analyze-logicreports orphaned rules.submissions-submitandsubmissions-validateacceptfield_values. Submissions refuse file upload values.Reference updates: entry timestamps, the empty
source_url, the entries-delete ownership check, and theorphanedflag in conditional logic.Testing instructions
./scripts/validate-skills.sh. Expect it to pass.skills/gravity-forms-abilities/SKILL.md. Confirm each rule matches the behavior in gravityforms/gravityforms#4045.change_log.txthas one 1.1.3 line per commit.Checklist: