Skip to content

Add: build-secret-github-token input - #291

Open
pascalholthaus wants to merge 6 commits into
mainfrom
pascalholthaus-patch-4
Open

pascalholthaus wants to merge 6 commits into
mainfrom
pascalholthaus-patch-4

Conversation

@pascalholthaus

@pascalholthaus pascalholthaus commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

What

Add: build-secret-github-token input

Why

Need it to download skiron and agent-control releases from github.

@pascalholthaus
pascalholthaus requested a review from a team as a code owner September 23, 2026 06:27
@greenbonebot
greenbonebot enabled auto-merge (rebase) September 23, 2026 06:27
@pascalholthaus
pascalholthaus enabled auto-merge (squash) September 23, 2026 06:30
Comment on lines +124 to +133
build-secrets: |
${{ format(
'{0}{1}',
contains(inputs.build-secret-greenbonebot, 'true')
&& format('"GREENBONE_BOT_PACKAGES_READ_TOKEN={0}"', secrets.GREENBONE_BOT_PACKAGES_READ_TOKEN)
|| inputs.build-secrets,
contains(inputs.build-secret-github-token, 'true')
&& format('"GITHUB_TOKEN={0}"', github.token)
|| ''
) }}

@y0urself y0urself Sep 23, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meine AI sagt, dass deine AI viel zu viel gemacht hat:

Suggested change
build-secrets: |
${{ format(
'{0}{1}',
contains(inputs.build-secret-greenbonebot, 'true')
&& format('"GREENBONE_BOT_PACKAGES_READ_TOKEN={0}"', secrets.GREENBONE_BOT_PACKAGES_READ_TOKEN)
|| inputs.build-secrets,
contains(inputs.build-secret-github-token, 'true')
&& format('"GITHUB_TOKEN={0}"', github.token)
|| ''
) }}
build-secrets: |
${{ contains(inputs.build-secret-greenbonebot, 'true')
&& format('"GREENBONE_BOT_PACKAGES_READ_TOKEN={0}"', secrets.GREENBONE_BOT_PACKAGES_READ_TOKEN)
|| inputs.build-secrets }}
${{ contains(inputs.build-secret-github-token, 'true')
&& format('"GITHUB_TOKEN={0}"', github.token)
|| '' }}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can make it even less complex with using input type boolean instead of string?

      build-secret-greenbonebot:
        type: boolean
        default: false
      build-secret-github-token:
        type: boolean
        default: false
      build-secrets:
        type: string
        default: ''
        build-secrets: |
          ${{ inputs.build-secret-greenbonebot
              && format('"GREENBONE_BOT_PACKAGES_READ_TOKEN={0}"', secrets.GREENBONE_BOT_PACKAGES_READ_TOKEN)
              || inputs.build-secrets }}
          ${{ inputs.build-secret-github-token
              && format('"GITHUB_TOKEN={0}"', github.token)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants