Skip to content

Fix ordering of selected versions when assembling the overlay - #46

Open
ziopio wants to merge 1 commit into
masterfrom
ziopio/overlay-hotfix
Open

Fix ordering of selected versions when assembling the overlay#46
ziopio wants to merge 1 commit into
masterfrom
ziopio/overlay-hotfix

Conversation

@ziopio

@ziopio ziopio commented Jul 28, 2026

Copy link
Copy Markdown
Member

The function collect_overlay was ordering the directory list but it was also missing 2 things:

  • ordering directories was putting the versions in order but that pushed "common" at the end of the list
    This was hiding the next bug when just one version folder is selected:
  • select_overlay_folders was not reversing the order of the list after the tail recursion

Now instead we do:

  • list everything,
  • filter out everything that is not an otp version folder
  • order such list
  • select
  • reverse selection order (to fix ordering)
  • put "common" at the head of the list

@ziopio
ziopio requested a review from maehjam July 28, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant