Repository navigation
fix: bump tldts from 7.4.15 to 7.4.16 in /apps/web - #2340
dependabot[bot] wants to merge 4 commits into
Conversation
Bumps [tldts](https://github.com/remusao/tldts) from 7.4.15 to 7.4.16. - [Release notes](https://github.com/remusao/tldts/releases) - [Changelog](https://github.com/remusao/tldts/blob/master/CHANGELOG.md) - [Commits](remusao/tldts@v7.4.15...v7.4.16) --- updated-dependencies: - dependency-name: tldts dependency-version: 7.4.16 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
Dependency ReviewThe following issues were found:
|
groupthinking
left a comment
There was a problem hiding this comment.
Review at head feeea3c2: this PR changes apps/web/package.json without updating the root package-lock.json, and current-head build, lint, and frontend test checks fail. Reconcile the workspace lockfile with the manifest, then rerun the checks before approval.
🔍 PR Validation✅ Current validation passed. |
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
groupthinking
left a comment
There was a problem hiding this comment.
Code review at exact head f83d2a2c5dff15bfb9ef5c6b35b97ba538b82833: the earlier requested change is resolved. The web manifest and root lockfile both install tldts@7.4.16 for the web app; the root tldts@7.4.15 entry is dev only. I inspected the two-file diff and verified a clean npm 10.8.0 install, package resolution, 1,520 passing web tests (28 skipped), lint, typecheck and build. Current hosted build, lint, frontend tests and issue-link checks pass. This approval covers the code and lockfile correction only. The shared dependency-review job still fails after a 3-base/1-head snapshot warning and has no reliable evidence artifact. Keep this PR open and unmerged until that check passes with a complete dependency verdict on the final head.
Bumps tldts from 7.4.15 to 7.4.16.
Release notes
Sourced from tldts's releases.
Changelog
Sourced from tldts's changelog.
Commits
b9519e0Bump version to: v7.4.16 [skip ci]06c6c7eUpdate CHANGELOG.md [skip ci]58f54b9Updates (#2691)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Codex verification — head
f83d2a2c5dff15bfb9ef5c6b35b97ba538b82833The update now includes
apps/web/package.jsonand the rootpackage-lock.json. The web workspace resolves directtldts@7.4.16. This branch was brought onto currentmain; the final no-content-change commit triggered checks against that corrected base.Local checks on the identical tree: clean npm 10.8.0
ci --ignore-scripts;npm ls tldts --workspace=apps/web --depth=0;npm test --workspace=apps/web(1,520 passed, 28 skipped);npm run lint --workspace=apps/web;./node_modules/.bin/tsc --noEmit -p apps/web/tsconfig.json;npm run build --workspace=apps/web;git diff --check. The npm audit still reports 33 other findings and notldtsortldts-coreentry.Hosted checks on this head: 23 passed, 3 skipped, and
dependency-reviewfailed. Its run40689881659compared three base dependency snapshots with one head snapshot, retried for 300 seconds, then exceeded the evidence template size limit and uploaded no review artifact. Its partial output reported no new moderate-or-higher vulnerability, but the snapshot warning prevents a complete dependency verdict. Keep this PR open until the shared dependency evidence check is repaired and rerun successfully at the final head.