Repository navigation
feat: add local durable review journal to agent actions - #2470
Draft
groupthinking wants to merge 2 commits into
Draft
groupthinking wants to merge 2 commits into
groupthinking wants to merge 2 commits into
Conversation
github-actions
Bot
added
ci/cd
documentation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🔍 PR Validation |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
✅ E2E Test Results: ALL TESTS PASSED
Test Output |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
Closes #2469
Outcome
Adds an off-by-default local durable journal to the agent actions review path. In
local-review-onlymode, trusted identity scopes persisted pending plans, exact artifact bytes are verified, and original actions remain unexecuted.Scope and paths
scripts/relay_harness/: Python SQLite and artifact journal, local CLI, and adapter.apps/web/src/lib/andapps/web/src/app/api/agents/actions/route.ts: Node bridge and opt-in route integration.tests/,apps/web/vitest.config.ts,.github/workflows/relay-review-journal.yml, anddocs/relay-durable-review-journal.md: regression tests, focused CI, and local-only usage.Risk and rollback
Risk: medium. An opt-in local host could return an incorrect receipt or permit an original action in review-only mode. Focused route, denial, byte-verification, and recovery tests cover these boundaries. Revert the two PR commits to roll back the integration and preview change. The feature remains off by default.
Verification
Exact PR head:
e3de2ae2d6ccb34b12dc1e0c2266eaf5e08a4e50. The second commit removes the branch-specific preview exclusion; the application tree and local regression code are unchanged from the first commit.TMPDIR=/private/tmp python3 -m unittest discover -s tests -p test_relay_local_harness.py -v.TMPDIR=/private/tmp node --test tests/relay-local-review.test.mjs tests/relay-review-route.test.mjs.TMPDIR=/private/tmp NEXT_TELEMETRY_DISABLED=1 npm --prefix apps/web test.npm --prefix apps/web run type-checkandnpm --prefix apps/web run lint: passed.Handoff
This remains a draft PR for review. The preview is user-approved. Production has not been changed, the PR is unmerged, and no live action was executed.