Repository navigation
fix: exempt verified Dependabot updates from issue closer - #2481
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Contributor
There was a problem hiding this comment.
🟢 Approved
No active review issues were identified for the scoped Dependabot exemption.
No open issues 🎉
What changed in this PR
Aligns the issue-closer gate with repository reconciliation policy by exempting verified Dependabot updates, addressing #2480 without changing production runtime behavior.
Changes:
- Exempts PRs only when authored by
dependabot[bot], originating from the same repository, and using adependabot/branch. - Preserves the open-issue requirement for other PRs and leaves other CI and security checks unchanged.
- Adds six regression cases covering the exemption and rejected metadata or issue states.
| File | Description |
|---|---|
tests/unit/test_require_issue_closer_workflow.py |
Adds parameterized tests for Dependabot eligibility and open-issue enforcement. |
.github/workflows/require-issue-closer.yml |
Adds event metadata checks and an early pass for qualifying Dependabot PRs. |
Review effort: Balanced
Contributor
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2480
Summary
dependabot/branches from the open-issue closing-keyword check.This aligns the issue-closer gate with the repository reconciliation workflow, which already excludes Dependabot dependency updates from missing-issue drift. PR #2462 currently has this as its only failed check.
Paths changed
.github/workflows/require-issue-closer.ymltests/unit/test_require_issue_closer_workflow.pytests/unit/test_dependency_review_workflow.py(aligns an existing license-policy assertion withmain)Validation
uv run --no-project --with pytest --with pyyaml python -m pytest -q -o addopts='' tests/unit/test_require_issue_closer_workflow.py tests/unit/test_dependency_review_workflow.py— 10 passed, covering accepted bot updates and rejected human/fork/mismatched/closed-issue cases.git diff --check— passed.All hosted checks on exact head
34bfcd0passed, and the pull request is mergeable. After this reachesmain, rerun the issue-closer check on a real Dependabot PR before calling the shared fix complete. No production runtime change is involved.