Repository navigation
fix: save dependency review evidence for large updates - #2487
Open
groupthinking wants to merge 4 commits into
Open
groupthinking wants to merge 4 commits into
groupthinking wants to merge 4 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsRe-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice. Scanned Files
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The evidence recorder ignores dependency-graph snapshot warnings, allowing successful API responses with incomplete dependency data to be recorded as complete evidence.
1 open issue
What changed in this PR
Addresses #2485 by moving dependency-review evidence collection from large Actions outputs to GitHub’s compare API, while retaining the existing vulnerability and license policy.
Changes:
- Fetches dependency data for exact base and head commits without workflow-template expansion.
- Saves the raw response alongside review metadata, change count, and SHA-256 digest.
- Updates artifact uploads and tests for large responses and evidence integrity.
| File | Description |
|---|---|
tests/unit/test_dependency_review_workflow.py |
Tests large-response preservation, metadata, digest, and workflow wiring. |
scripts/ci/record_dependency_review.py |
Adds API-based dependency evidence recording. |
.github/workflows/dependency-review.yml |
Runs the recorder and uploads the evidence directory. |
Review effort: Balanced
This was referenced Oct 28, 2026
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Contributor
🔍 PR Validation |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2485
Paths changed
.github/workflows/dependency-review.ymlscripts/ci/record_dependency_review.pytests/unit/test_dependency_review_workflow.pyValidation
tests/unit/test_dependency_review_workflow.pysuite — 19 passed on the final head, including warned empty/partial responses, a warning-free empty response, graph drift rejection, and a real Git rename regression.uvx ruff check scripts/ci/record_dependency_review.py tests/unit/test_dependency_review_workflow.py— passed.git diff --check— passed.Hosted validation and limits
The current head is
148cbf55fdce412255d2a61780459143521fa4c4. Its hosted checks are being verified on that exact head; see the live check list for final status. The dependency-review job passes through its no-delta path because this PR changes no dependency manifest or lockfile. Its hosted run tests the code-only path, while a real dependency PR must still validate the evidence recorder against a warning-free comparison. The Vercel Agent Review found that Git rename detection could omit an old manifest path;--no-renamesand a real Git rename regression test address that finding. The review thread is resolved.An earlier hosted artifact on superseded head
80fdf2bcontained a raw 276-entry comparison whose bytes matched its recorded digest. GitHub also warned that the base had 3 dependency snapshots and the head had 1. That comparison may have unexpected removals and is not complete evidence under the new guard. The prior local trial against #2479 saved 1,390 raw changes before snapshot warnings were checked; it likewise cannot establish a complete comparison.Live recorder check and graph scope limitation
At the current code head, the local recorder rejects the live, warning-free #2495 comparison without writing evidence, because its removed root fast-uri 3.1.7 entry is labeled
runtimewhile the exact base lockfile marks itdev: true. It also rejects currentmainversus #2452 before writing evidence because GitHub reports a 3-base/1-head snapshot warning. In contrast, it accepts controlled off-main #2496: the v0.2.0 comparison has only the intended root fast-uri 3.1.7 removal and 3.1.9 addition, bothdevelopment, and the saved raw bytes match the recorded SHA-256. #2496 was closed unmerged.The older v0.1.6 component-detection action caches packages by PURL and can apply one development flag across manifests. The v0.2.0 action used on #2496 maps each manifest's scope separately; that version is proposed in stacked draft #2492. The new recorder validation reduces the risk of accepting a wrong npm lockfile scope or a change attributed to an unchanged manifest. It does not establish complete snapshot parity or accurate non-npm package metadata for real updates against current
main. Inspect the full comparison, including manifests, packages, scopes, vulnerabilities, and licenses, before a real dependency PR verdict.A fresh compare for #2452 still reports the base 3/head 1 snapshot mismatch. Once this guard is on
main, that update will require complete matching snapshots before its dependency evidence can pass.The previously approved per-file Python scan timeout and declared-dependency fallback are unchanged. Python fallback can omit transitive dependencies when a requirements scan times out.