Adopt proto_lang_toolchain for java_grpc_library() - #12994
Open
AgraVator wants to merge 6 commits into
Open
Conversation
AgraVator
marked this pull request as ready for review
August 18, 2026 17:09
ejona86
reviewed
Aug 18, 2026
ejona86
reviewed
Aug 25, 2026
| java_info = java_common.compile( | ||
| ctx, | ||
| java_toolchain = toolchain.java_toolchain[java_common.JavaToolchainInfo], | ||
| java_toolchain = ctx.toolchains["@bazel_tools//tools/jdk:toolchain_type"].java, |
Member
There was a problem hiding this comment.
I'm surprised to see a literal being passed here. Is that not defined somewhere?
Contributor
Author
There was a problem hiding this comment.
Bazel does not expose an importable constant for this toolchain type, so using the literal string as was being done at https://github.com/protocolbuffers/protobuf/blob/main/bazel/private/java_proto_support.bzl#L43
| source_jars = [srcjar], | ||
| output = ctx.outputs.jar, | ||
| output_source_jar = ctx.outputs.srcjar, | ||
| plugins = [plugin[JavaPluginInfo] for plugin in toolchain.java_plugins], |
Member
There was a problem hiding this comment.
It looks like we need to still support this, as there are usages internally. I don't know if that means we need a second toolchain, or what.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.