xds: Ext proc client drop backend_service metrics label, make eos_without_message conditional on eos field - #13028
Open
kannanjgithub wants to merge 6 commits into
Open
xds: Ext proc client drop backend_service metrics label, make eos_without_message conditional on eos field#13028kannanjgithub wants to merge 6 commits into
kannanjgithub wants to merge 6 commits into
Conversation
Remove redundant isCompleted check from isSidecarReady and null checks from recordDuration. TAG=agy CONV=9ea901ca-a127-468c-a836-414f2154bf85
The ext_proc spec has been updated to drop adding the backend_service metric label. TAG=agy CONV=86c74ebe-9fd7-4876-b27c-a4c1b230d346
…without_message per ext_proc spec
# Conflicts: # xds/src/main/java/io/grpc/xds/ExternalProcessorClientInterceptor.java # xds/src/test/java/io/grpc/xds/ExternalProcessorClientInterceptorTest.java
…aster merge - Drop backend_service metric label from ExternalProcessorClientInterceptor. - Set end_of_stream on client half-close alongside end_of_stream_without_message. - Handle end_of_stream_without_message per ext_proc spec on StreamedBodyResponse. - Update tests and mocks to reflect the updated half-close semantics. TAG=agy CONV=86c74ebe-9fd7-4876-b27c-a4c1b230d346
TAG=agy CONV=86c74ebe-9fd7-4876-b27c-a4c1b230d346
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing dropping backend_service metrics label, and the discrepancy with the gRFC in
end_of_stream_without_messagehandling. The code treats this field independently, but as per the gRFC it should be only be considered when theend_of_streamfield is true. This applies both inProcessingRequestandProcessingResponse.