Skip to content

Separate Terraform plan and apply roles for incubator #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ale210 merged 5 commits into from
Mar 12, 2026
Merged

Separate Terraform plan and apply roles for incubator #147

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c4d956
Separate Terraform plan and apply roles for incubator
Benettonkkb Feb 5, 2026
3178e81
Applying recommended role detail changes for plan and apply
Benettonkkb Feb 26, 2026
bb7db35
Removed Pull Request condition from incubator_tf_apply
Benettonkkb Mar 12, 2026
0db4651
Removed Supervisors group reference in terraform/aws-groups.tf
Benettonkkb Mar 12, 2026
27f1c8c
Removed iam-services-supervisor group from Chelseyb account
Benettonkkb Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions terraform/aws-gha-oidc-providers.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,47 @@ module "iam_oidc_gha_incubator" {
policy_arns = [
"arn:aws:iam::aws:policy/AdministratorAccess"
]

}
module "iam_oidc_incubator_tf_plan" {
Comment thread
Benettonkkb marked this conversation as resolved.
Outdated
source = "./modules/aws-gha-oidc-providers"

role_name = "incubator-tf-plan"
use_wildcard = true
github_branch = "refs/heads/*" # concerning IAM audit, ok, as it is read-only
github_repo = "hackforla/incubator"

policy_arns = [
"arn:aws:iam::aws:policy/ReadOnlyAccess"
]
}
resource "aws_iam_role" "incubator_tf_apply" {
name = "incubator-tf-apply"

assume_role_policy = jsonencode({
Version = "2012-10-17"
Statement = [
{
Effect = "Allow"
Action = "sts:AssumeRoleWithWebIdentity"
Principal = {
Federated = module.iam_oidc_gha_incubator.provider_arn
}
Condition = {
StringEquals = {
"token.actions.githubusercontent.com:aud" = "sts.amazonaws.com"
}
StringLike = {
"token.actions.githubusercontent.com:sub" = "repo:hackforla/incubator:ref:refs/heads/main"
Comment thread
Benettonkkb marked this conversation as resolved.
Outdated
}
}
}
]
})
}

resource "aws_iam_role_policy_attachment" "incubator_tf_apply_admin" {
role = aws_iam_role.incubator_tf_apply.name
policy_arn = "arn:aws:iam::aws:policy/AdministratorAccess"
}