Update project profile - #8788
davidsan13 wants to merge 1 commit into
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
yepezjuan
left a comment
There was a problem hiding this comment.
Hello David,
Code additions look appropriate, visual changes to the website do not affect any previous content. PR formatting looks good as well
Great work David
|
Availability for this week: Every day after 8PM ET |
|
Availability:
ETA:
|
cchrizzle
left a comment
There was a problem hiding this comment.
Hi @davidsan13,
Looks good to me!
- You implemented the requested changes
- You included before and after screenshots
- You have the correct branch naming convention
Just one note: you checked both options for the CodeQL alerts section when I believe it should be one or the other, and you checked all the sub-options for the second option when it looks like it should just be one. You don't need to check all the boxes for this, just the one that applies to you (I think in this case, the first option "I have checked this PR for CodeQL alerts and none were found." should be good). Just a heads up for future reference, but great job regardless!
Fixes #8761
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied