Repository navigation
chore: enable skipLibCheck in the base tsconfig - #432
Merged
Merged
Conversation
Every package's typecheck re-checked ~70k lines of third-party declarations (@types/node, the DOM lib, vitest/vite) that no package here authors. Skipping them cuts `pnpm run typecheck` from ~28s to ~10s. Generated dist/*.d.ts come from already-checked source, and the only hand-written declarations (record-adapter-do-sqlite) were already skipped, so its now-redundant override is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm run typecheckspent most of its time re-checking third-party declaration files: each of the 12 packages type-checked ~70k lines of.d.ts(@types/node, the DOM lib, vitest/vite; ~127k forblob-adapter-s3with the AWS SDK), even packages with a few hundred lines of their own code.This sets
skipLibCheck: trueintsconfig.base.jsonand drops the now-redundant override fromrecord-adapter-do-sqlite.Spec
No behavior change. Emitted output is unaffected, so no changeset.
Verification
Ran all six pre-push checks:
format:check,check:refs,lint,test,build,typecheck. All pass.Notes for reviewers
skipLibCheckalso skips hand-written.d.tsin the repo. The only ones (record-adapter-do-sqlite'sworker-configuration.d.tsandtests/support/env.d.ts) were already skipped by that package's config. Siblingdist/*.d.tsare generated from source that is itself type-checked.The remaining ~10s is mostly fixed per-process overhead (each package's
tscreloads the same lib types). Project references /tsc -bcould cut that further, but it's a bigger change and probably not worth it at this size.🤖 Generated with Claude Code