[HZ-5415] Asyncio cancellation tests#821
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #821 +/- ##
==========================================
- Coverage 94.20% 94.19% -0.02%
==========================================
Files 411 411
Lines 27511 27513 +2
==========================================
- Hits 25918 25915 -3
- Misses 1593 1598 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
emreyigit
reviewed
Jun 16, 2026
| return | ||
| except Exception as e: | ||
| invocation.future.set_exception(e) | ||
| if not invocation.future.cancelled(): |
Member
There was a problem hiding this comment.
One thing looks interesting. Future is checked here whether canceled but not in _complete_with_error. Does it matter?
| async def test_cancel(self): | ||
| async def keep_setting(): | ||
| for i in range(1000): | ||
| print(i) |
Member
There was a problem hiding this comment.
Not important but this may be noisy.
emreyigit
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've improved cancellation behavior and added cancellation tests.