Skip to content

feat: update accounts:remove to work with credential manager#3701

Merged
k80bowman merged 2 commits into
feat/credential-mgr-integrationfrom
k80/accounts-remove
May 12, 2026
Merged

feat: update accounts:remove to work with credential manager#3701
k80bowman merged 2 commits into
feat/credential-mgr-integrationfrom
k80/accounts-remove

Conversation

@k80bowman
Copy link
Copy Markdown
Contributor

Summary

Updates the accounts:remove command to work with the credential manager.

Type of Change

Breaking Changes (major semver update)

  • Add a ! after your change type to denote a change that breaks current behavior

Feature Additions (minor semver update)

  • feat: Introduces a new feature to the codebase

Patch Updates (patch semver update)

  • fix: Bug fix
  • deps: Dependency upgrade
  • revert: Revert a previous commit
  • chore: Change that does not affect production code
  • refactor: Refactoring existing code without changing behavior
  • test: Add/update/remove tests

Testing

Notes:

  1. Check out this branch and run npm i && npm run build
  2. Run ./bin/run login to log in to your first account.
  3. Run heroku accounts:add account1 to add this account to your accounts cache for .netrc
  4. Logout of this account in the browser and then log in to a second account
  5. Run ./bin/run login to log in to your second account
  6. Run heroku accounts:add account2 to add this second account to your accounts cache for .netrc

Steps:

  1. Run ./bin/run accounts and you should see the email addresses for the two accounts
  2. While logged in to account2, run ./bin/run accounts:remove <email address for account1>
  3. Run ./bin/run accounts and you should only see the email address for account2
  4. Run HEROKU_NETRC_WRITE ./bin/run accounts and you should see the email addresses for the two accounts again.
  5. Run HEROKU_NETRC_WRITE ./bin/run accounts:remove <email address for account1>
  6. Run HEROKU_NETRC_WRITE ./bin/run accounts and you should only see the email address for account2

Screenshots (if applicable)

Related Issues

GUS work item: W-22247998

@k80bowman k80bowman requested a review from a team as a code owner May 11, 2026 20:19
@k80bowman k80bowman temporarily deployed to AcceptanceTests May 11, 2026 20:19 — with GitHub Actions Inactive
@k80bowman k80bowman temporarily deployed to AcceptanceTests May 11, 2026 20:19 — with GitHub Actions Inactive
@k80bowman k80bowman temporarily deployed to AcceptanceTests May 11, 2026 20:19 — with GitHub Actions Inactive
@k80bowman k80bowman temporarily deployed to AcceptanceTests May 11, 2026 20:19 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

@tlowrimore-heroku tlowrimore-heroku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍 👍

@k80bowman k80bowman merged commit 89d7b14 into feat/credential-mgr-integration May 12, 2026
17 checks passed
@k80bowman k80bowman deleted the k80/accounts-remove branch May 12, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants