Skip to content

Better convolve1d implementation on jax and torch#52

Open
hexane360 wants to merge 4 commits into
developfrom
convolve1d-test
Open

Better convolve1d implementation on jax and torch#52
hexane360 wants to merge 4 commits into
developfrom
convolve1d-test

Conversation

@hexane360
Copy link
Copy Markdown
Owner

  • On jax, convolve1d uses conv_general_dilated directly, which should dispatch to a 1D convolution rather than a 3D convolution with kernel size (1, 1, N).
  • On torch, xp.pad has a fallback for cases torch.nn.functional.pad doesn't support
  • On torch, convolve1d now uses xp.pad. Importantly, kernel size >= object size now works
  • Add test cases for xp.pad

@hexane360 hexane360 requested a review from mlz-EM May 22, 2026 19:59
@hexane360
Copy link
Copy Markdown
Owner Author

@mlz-EM can you review when you get a chance? Would be helpful if you could benchmark layers regularization on jax before and after, make sure it's not significantly slower

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant