Repository navigation
docs: rename the Workflows nav group to Make a video and drop retired workflow steps - #5655
Conversation
jrusso1020
left a comment
jrusso1020
left a comment
There was a problem hiding this comment.
Reviewed own seven-file stacked diff at exact 4d504b2e6852f7f05f6625a165b4e968b50abf25.
docs/docs.json:161 changes only Workflows → Make a video: parsing both versions and restoring that one label produces structurally identical navigation. All existing page paths remain. The six guide edits replace mandatory interview/confirmation claims with explicit request choices or an optional proposal/storyboard, matching the retained /hyperframes entry. PR release-state checking remains explicit; no retired skill is newly advertised.
Read all seven changed files and patches, checked navigation equality and preservation of page identities. No Mintlify build or full broken-link crawl was run by me. This review covers this docs diff only; it does not clear #5651's independent craft-sampling blocker. Land/retarget in stack order after its base is ready.
Verdict: APPROVE
Reasoning: The rename preserves navigation and the guide copy agrees with the new skill behavior, without a code or link change.
— hf-review
The base branch was changed.
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
… workflow steps The per-workflow guides now route through /hyperframes, so the sidebar group names what the reader wants to do rather than skills that no longer ship. The guides no longer promise a confirmation round the retired workflow skills ran (the interview and brief); they say what to put in the request and when to ask for a proposal or storyboard first. URLs are unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
4d504b2 to
f8df675
Compare
jrusso1020
left a comment
jrusso1020
left a comment
There was a problem hiding this comment.
Re-reviewed exact f8df675fe628e75c16181f7a7502f151e07f7b23 after #5651's squash merge.
The seven-file added/deleted lines match approved 4d504b2e exactly. All six guide files are byte-identical. The nav file includes newer main content; parsing current base/head and reverting only Make a video → Workflows produces identical structures, so no current-main pages or navigation were lost.
The preceding wording/link audit stands. No new Mintlify build or full broken-link crawl performed. Miao explicitly authorized the armed auto-merge; I did not merge or enqueue.
Verdict: APPROVE
Reasoning: The rebase preserves the approved docs-only change and all current-main navigation.
— hf-review
jerrai-bot-heygen
left a comment
jerrai-bot-heygen
left a comment
There was a problem hiding this comment.
Reviewed the seven-file docs/nav diff at this exact head after #5651 landed. The nav change preserves the current-main page list and changes only the group label; the six guide edits make storyboard/proposal-first an explicit request choice rather than an unconditional agent step. The current-head Format and Comments jobs executed successfully; Validate docs is still running and remains an independent merge gate. This approval does not perform a manual merge or release. — Jerrai
This branch was successfully deployed
3 participants
What
Renames the docs sidebar group Workflows to Make a video (
docs/docs.json, one line) and makes small wording fixes in six of its guide pages so they describe the seven-skill pack as it is. No page is added, removed, or moved; every URL stays the same.Stacked on #5651. The base is
miao/oss-skills-slim, so this diff shows only the docs change. Retarget tomainafter #5651 merges.Why
#5651 retires the workflow skills (
product-launch-video,faceless-explainer,pr-to-video,general-video,motion-graphics,music-to-video, ...). Their guide pages now say "Using /hyperframes", but they were still grouped under "Workflows", and several still described the retired skills' confirmation step: the agent "proposes a direction and confirms", "Before it builds / Confirm:". That was the old interview andBRIEF.mdgate. Thehyperframesskill now builds what is asked, offers a storyboard on request (references/storyboard.md), and answers a loose idea with a proposal.The rename was first made inside #5651 and then reverted there (bc4653c).
scripts/check-catalog-source-pr.mjslistsdocs/docs.jsonas generated catalog output, and refuses it in any PR that also touchesregistry/{blocks,components,examples}/sources. #5651 touches those sources; this PR does not.Related work
Refs #5651
How
docs/docs.json:"group": "Workflows"→"group": "Make a video". The catalog generators (scripts/generate-catalog-pages.ts,scripts/build-docs-gallery-nav.mjs) only rewrite the Catalog tab, so a later catalog publish will not revert this.check-catalog-source-pr.mjsallows: if the diff touches noregistry/(blocks|components|examples)/file, the script returns immediately. A docs-nav-only PR therefore passes, andscripts/catalog-publication.test.mjsasserts the same (committedCatalogOutputs(["docs/docs.json"])is[]).product-launch-video: the agent captures the product and builds from it; ask for a storyboard first if you want to approve the shots.faceless-explainer,general-video,motion-graphics: "the agent proposes ... and confirms" becomes "say X in the request, or ask for a proposal first". Themotion-graphicspage no longer capitalizes "Motion Graphics" as a product name.pr-to-video,captions-and-recuts: "Before it builds / Confirm:" becomes "Settle these in the request, or ask the agent to propose them first:".pr-to-videokeeps its release-state claim, becausereferences/film.mdstill says "Never invent a version".workflows.mdx,music-to-video,slideshowandhyperframes-vs-remotionalready describe the current skills. No page mentionsskills update <workflow>.Test plan
node scripts/check-catalog-source-pr.mjs origin/miao/oss-skills-slim→ exit 0. Againstorigin/mainit fails while feat(skills)!: publish seven knowledge skills aligned with Studio and retire the workflow skills #5651 is unmerged, because the merge-base diff includes feat(skills)!: publish seven knowledge skills aligned with Studio and retire the workflow skills #5651's registry edits. It passes once this PR is retargeted after feat(skills)!: publish seven knowledge skills aligned with Studio and retire the workflow skills #5651 merges.node scripts/check-docs-catalog.mjs→PASS no page lost: 448 pages before, 448 after; all four checks pass.cd docs && npx mint validate→success build validation passedcd docs && npx mint broken-links --check-redirects→success no broken links foundnode scripts/check-docs-snippet-motion.mjs→ exit 0bun run lint→ exit 0 (oxlint: 0 warnings, 0 errors; skills lint, core-skills and skill mirror pass)bunx oxfmt --check --no-error-on-unmatched-pattern docs/docs.json docs/guides/*.mdx→ "No files found matching the given patterns" (oxfmt does not coverdocs/), exit 0COMMENT_CHECK_BASE=origin/miao/oss-skills-slim node scripts/check-comment-citations.mjs→nothing to check (7 changed file(s), none scannable)The
CI,DocsandPR capturesworkflows run only for PRs intomain, so they will run when this PR is retargeted.No visible change
This PR changes docs only. Nothing under
packages/studioorpackages/playerchanges.🤖 Generated with Claude Code