Skip to content

fix(cli): exclude rendering flags from tween tail warnings - #5711

Open
rudycelekli wants to merge 1 commit into
heygen-com:mainfrom
rudycelekli:rudy/fix-gsap-tween-tail-control-flags
Open

rudycelekli wants to merge 1 commit into
heygen-com:mainfrom
rudycelekli:rudy/fix-gsap-tween-tail-control-flags

Conversation

@rudycelekli

@rudycelekli rudycelekli commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

check can warn that two tweens conflict even when they animate different properties: shared force3D and autoRound options are currently counted as animated properties. Exclude those CSSPlugin rendering flags, while retaining warnings for genuinely shared properties.

Fixes #5683.

Validation:

  • The same focused public test file runs 8 tests: baseline fails the two new regression cases; patched source passes all 8, including the genuine shared-property control. Vitest 4.1.11 / happy-dom 20.11.2, with an explicit minimal one-file config and a pre-existing dependency provider; this was not the complete CLI config or a real GSAP/browser test.
  • Additional production collector/detector checks cover each flag independently, both flags, and no flags with disjoint/shared real properties: patched 8/8 pass.
  • The standalone utility bundles with Bun 1.3.13. Repository-config Oxlint 1.64.0 (lockfile version), Oxfmt 0.41.0, comment citations and comment ratchet pass.

Validation limitations: the prescribed workspace build was attempted and failed because tsup is unavailable. Full workspace build, typecheck, suite and real-browser CLI verification have not passed locally.

@jrusso1020 jrusso1020 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. This is the right minimal fix.

What I checked:

  • packages/cli/src/utils/gsapTweenTails.ts:79-80 adds force3D and autoRound to NOT_PROPERTIES. plainProperties filters Object.keys(vars) against that set, so neither key can count as a shared property in findTweenTails any more. This matches the cause described in #5683.
  • I ran vitest run src/utils/gsapTweenTails.test.ts and got 8 passed. I then reverted gsapTweenTails.ts to main, and both new tests fail (the flags-only pair and the shared-opacity control). The tests catch the regression, and the control proves real overlaps are still reported.

Optional, same class of bug: clearProps is another CSSPlugin instruction, not an animated value. Two overlapping tweens that both pass it would hit the same false warning. Adding it here would be harmless, but it can also wait until someone reports it.

— Rames

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gsap_tween_tail counts GSAP's force3D and autoRound flags as properties

2 participants