Repository navigation
fix(cli): exclude rendering flags from tween tail warnings - #5711
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
jrusso1020
approved these changes
Oct 17, 2026
jrusso1020
left a comment
Collaborator
There was a problem hiding this comment.
Approving. This is the right minimal fix.
What I checked:
packages/cli/src/utils/gsapTweenTails.ts:79-80addsforce3DandautoRoundtoNOT_PROPERTIES.plainPropertiesfiltersObject.keys(vars)against that set, so neither key can count as a shared property infindTweenTailsany more. This matches the cause described in #5683.- I ran
vitest run src/utils/gsapTweenTails.test.tsand got 8 passed. I then revertedgsapTweenTails.tstomain, and both new tests fail (the flags-only pair and the shared-opacitycontrol). The tests catch the regression, and the control proves real overlaps are still reported.
Optional, same class of bug: clearProps is another CSSPlugin instruction, not an animated value. Two overlapping tweens that both pass it would hit the same false warning. Adding it here would be harmless, but it can also wait until someone reports it.
— Rames
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkcan warn that two tweens conflict even when they animate different properties: sharedforce3DandautoRoundoptions are currently counted as animated properties. Exclude those CSSPlugin rendering flags, while retaining warnings for genuinely shared properties.Fixes #5683.
Validation:
Validation limitations: the prescribed workspace build was attempted and failed because
tsupis unavailable. Full workspace build, typecheck, suite and real-browser CLI verification have not passed locally.