Repository navigation
fix(cli): history list never prints 60m ago or 24h ago - #5818
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hyperframes historyprints relative ages that read as the next unit's size:60m agoand24h ago.Why
ago()rounds each unit. An entry 3,570 s old (59.5 minutes) prints60m agoinstead of59m ago, and one 86,000 s old prints24h agoinstead of23h ago.Related work
No overlapping PR found. Related in spirit to #5817 (rounding rollover in
ui/format.ts), but touches a different file.How
Floor minutes, hours and days; seconds stay rounded. The function moves unchanged in shape into
utils/historyAgo.tsand takesnowas an argument, so it can be tested without the history command's workspace dependencies.Test plan
utils/historyAgo.test.ts. The boundary case fails with the old rounding and passes with the fix (vitest run src/utils/historyAgo.test.ts).oxfmt --checkandoxlintclean on changed files.Not run locally:
history.test.tsand workspace typecheck (workspace packages were not installed), comment citation/ratchet scripts.