Repository navigation
feat(cli): preserve page motion blur off in local renders - #6081
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Edit accuracy: accurate 271 (base branch 271), smooth 180 of thoseThe gate passes. Quarantined, measured but not gated (0) |
jrusso1020
left a comment
There was a problem hiding this comment.
Reviewed at d6207ac. No blockers in the supported local-render scope.
If the flag is omitted it stays undefined, so a composition keeps its authored blur behaviour rather than having blur forced on everywhere. The validated plan forwards off through the existing paths:
- single and batch render options;
- Docker argv;
- the producer's existing request, config, compile, probe and capture override.
Distributed and Lambda renders already turn page blur off in synthetic jobs and chunk capture. This PR doesn't add a hosted-cloud CLI flag or send the setting from Desktop.
Legacy cache tradeoff: every old segment directory goes cold, default renders included. The PR documents this; it does not preserve old caches. Comparing old and new hashes directly:
- the legacy hash gives the same key for undefined and
off; - the new hash gives them distinct keys.
The producer accepted off before this CLI flag existed, and legacy manifests don't record the setting. Reusing legacy keys blindly could therefore pick up segments rendered with an unknown blur mode. The one-time migration is justified, and renders whose settings don't change keep sharing a key afterwards.
Testing
- 58 Docker-argv and segment-manifest tests pass, using current-source aliases and borrowed dependencies.
- Six direct strict-parser controls pass.
- The broader CLI suites couldn't collect locally, because core's generated runtime is missing.
- Not run: Chrome output and resume pixels, Docker containers, and hosted renders.
Review by Rames (hf-review)
The CLI cannot currently request the renderer's existing page motion blur override. Add
hyperframes render --page-motion-blur off, preserve it through single, batch and Docker renders, and keep omission as the composition's authored behavior. Invalid values are rejected before render setup.The override also becomes part of the segmented-resume identity. Changing blur settings captures fresh segments; repeating the same settings can still reuse them. Existing segment directories become cold cache.
Validation on Linux:
Local commit hooks were skipped; the checks above ran on Linux. Docker forwarding is covered by argv tests, not a container render. Hosted cloud API forwarding and Desktop request production are separate follow-ups and are not implemented here.