Skip to content

fix(cli): report failed tag installations to scripts and agents - #6086

Open
AksharP5 wants to merge 1 commit into
heygen-com:mainfrom
AksharP5:fix/cli-tag-install-failures
Open

AksharP5 wants to merge 1 commit into
heygen-com:mainfrom
AksharP5:fix/cli-tag-install-failures

Conversation

@AksharP5

Copy link
Copy Markdown
Contributor

What

hyperframes add <tag> now reports an incomplete installation as a failure. Scripts and agents receive exit code 1 and ok: false when any block fails; JSON includes each failed block's name and error. Successful installations remain available.

Why

The tag loop catches each install error and then reports unconditional success. In JSON mode, it also drops every failure reason.

The same real source CLI process with fixture HTTP responses:

Download results Before After
All fail with HTTP 404 Exit 0; ok: true; no files; no errors Exit 1; ok: false; named HTTP 404 error
One fails, one succeeds Exit 0; ok: true Exit 1; ok: false; successful HTML preserved
All succeed Exit 0; ok: true Exit 0; ok: true; errors: []

The issue includes a self-contained reproduction. Only HTTP responses are fixtures; dispatch, resolution, installation, filesystem writes and process exit handling use the real implementation.

Related work

Fixes #6084.

#4432 preserves warnings from successful installs. Open #5256 refreshes item manifests during discovery; neither handles failed file installation.

How

Collect per-item errors, derive JSON status from the collection and use the existing command-failure boundary after the batch finishes. The human summary marks incomplete installs as an error. Document the exit status and JSON fields.

Test plan

  • Command regressions cover total failure, partial failure, success and non-JSON failure.
  • Failure regressions fail on the base implementation.
  • Add, installer and resolver suites: 71 passed.
  • Actual source CLI process before/after inspected, including exit status and installed files.
  • Changed TypeScript passes oxlint and oxfmt; diff whitespace check passes.
  • CLI documentation updated; comment/process-ownership checks run before push.

Validated on main 10c724bf5, Linux x86_64, Node 26.11.1, Bun 1.4.1 (repository pins 1.4.4), and Citty 0.2.2. CLI TypeScript checking reports a missing installed @aws-sdk/s3-request-presigner dependency through AWS Lambda source and no changed-file type errors. Full workspace checks have the same dependency limitation; mint is absent, so full docs validation was not run.

@mintlify

mintlify Bot commented Oct 22, 2026

Copy link
Copy Markdown

Preview approval required

This pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit 8eb2f1d.

Approve preview

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add by tag reports success when block downloads fail

1 participant