Repository navigation
fix(ci): a package fails its size budget only when more than 1% over it - #6131
Merged
Merged
Conversation
The budgets are the exact packed sizes people last measured, so a few hundred bytes of ordinary code failed Build. The exact budget stays the number to bump and the 15% ratchet stays; only the over-budget comparison gets 1% of tolerance.
Contributor
There was a problem hiding this comment.
Verdict: APPROVE · 0 blocker · 0 important · 0 nits · head 02ea2d35
Scope
The tolerance only changes the over-budget comparison (budget × 1.01). The budget stays the cap, so slack can't pile up across PRs. The 15% ratchet and the 5% suggested-budget headroom (:563) are unchanged, and publish.yml runs the same script. With the new rule, #6104's studio-server (+325 B of 141718) and #6127's engine (+215 B) pass, and a stray sourcemap or test directory still fails. Lint, Typecheck, Build and every Test job passed at this head.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package size budgets are the exact packed sizes someone last measured, so any PR that adds ordinary code fails Build on a few hundred bytes. This lets a package go up to 1% over its budget before
verify:packed-manifestsfails. The budget inscripts/package-size-budgets.jsonstays the number people bump, and the 15% ratchet that makes a shrinking package lower its budget is unchanged.Measured against what the guard exists to catch (a stray sourcemap, tests or assets in the tarball):
@hyperframes/aws-lambda@hyperframes/engine@hyperframes/studio-server@hyperframes/aws-lambdaTolerance per package is small in bytes: aws-lambda 733 B packed and 2.7 KB unpacked, engine 4.3 KB, studio-server 1.4 KB. A stray tests directory or sourcemap is tens of KB to MB, over 5% on every package. The 150 MB Lambda zip class is guarded separately by
verify:zip-size.The new test fails without the change: with
verify-packed-manifests.mjsfrom main the two size tests fail, with the change all 23 pass (run on a built tree).No visible change
Build tooling only.