Repository navigation
Support renderers for args in addMultilineCall #68
Description
Activity
I'm not sure how to design this in a way that works reasonably well for both all-args-have-same-renderer and different-renderer-per-arg.
It might be best to add a
HackBuilderValuetype which includes both aTand aIHackBuilderValueRenderer<T>, and take multiple hackbuildervaluesThis is probably worth looking at v5, which hopefully won't be as long away as v3 => v4 :)
Waking this issue from its multi year slumber. My instinct says: Why not both?
Keep the current addMultilineCall() around, since requiring a builder for a
trueliteral would be cumbersome. Add a new method which takes on builder and apply it to all arguments.I am not sure a third version taking builder+value pairs would be much more convenient than using the builders at the call site. There is no need to add this in the same PR, so that may/might be postponed (indefinitely?).
For our current use of
addMultilineCall, it's fairly common to pass literals as arguments, including nested arrays. Would be nice if we could useHackBuilderValues::export()rather than having to do it manually.