Skip to content

Close phase 7 in the roadmap and open phase 8 - #23

Merged
rohan-hotdata merged 2 commits into
mainfrom
close-phase-7
Oct 15, 2026
Merged

rohan-hotdata merged 2 commits into
mainfrom
close-phase-7

Conversation

@rohan-hotdata

Copy link
Copy Markdown
Collaborator

This PR closes phase 7 in the roadmap and opens phase 8 as #22. It changes docs only.

How:

  • docs/internal/roadmap.md: phase 7 is closed on 2026-10-14 with PR Phase 7: the extractor #21, and phase 8 is open as Phase 8: episodes behind facts #22. A closing paragraph for phase 7 records its results and how it changes later phases. "More extractor prompts" goes under Deferred, because detail met a stop condition.
  • docs/internal/plan.md: the phase 7 section is removed. Its plan stays in git history at ab93da1. The start table gains the detail results: 31 of 54 on sample A and 32 on sample B. The extractor fact and the fixed-models decision now name detail and the fact source.
  • Phase 8 in the plan:
    • It names the detail configuration as its baseline, and the groups of misses it targets.
    • It names what fact sources mean for the episode key and the extractor cache. These points are read from source, not observed.
    • It gains a diagnosis task for episodes in the block.
    • It gains an acceptance criterion: the best value scores more than 31 on A and more than 32 on B.
    • It gains the $50 stop condition.

Why: the roadmap rule says that the next phase opens only after the previous phase closes. Issue #22 holds the same phase 8 brief as the plan.

Verification: make verify passes. A search of the added lines found no private names.

Phase 7 closed with PR #21. The roadmap records what it changed for later
phases, and lists more extractor prompts under Deferred. The plan drops
phase 7, adds the detail results to its start point, and gives phase 8 the
detail baseline, its target groups, and what the fact sources mean for the
episode key.
@rohan-hotdata
rohan-hotdata requested a review from a team as a code owner October 15, 2026 07:05
@rohan-hotdata
rohan-hotdata requested review from zfarrell and removed request for a team October 15, 2026 07:05
Comment thread docs/internal/mem0-survey.md Outdated
@@ -0,0 +1,348 @@
# mem0 survey: how it extracts, stores, and recalls memories

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Name docs/internal/mem0-survey.md in the PR description, or move it to its own PR (not blocking).

The description says the PR closes phase 7 and opens phase 8, and lists only roadmap.md and plan.md. A reviewer who reads only the description misses 348 added lines. AGENTS.md also lists every internal doc under "Where things are", and the survey has no entry there.

Comment thread docs/internal/mem0-survey.md Outdated

The accuracy comes mostly from the extraction prompt, not from the storage or the retrieval
machinery. This matches the hotmemory diagnosis: 19 of the 35 memory misses on sample A were facts
that the extractor never wrote (`hotmemory/docs/benchmarks.md:180-191`).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Change the citation to docs/benchmarks.md:221-228 (not blocking).

Lines 180-191 of docs/benchmarks.md now hold the replay notes and the start of sample B. The "19 of 35" counts are at lines 221 and 226. The hotmemory/ prefix also does not resolve inside this repository. The same prefix appears at line 10.

Comment thread docs/internal/mem0-survey.md Outdated
1. Extraction prompt (19 of 35 misses). Our prompt asks for "facts that a personal assistant
must remember about the user", as "one short sentence". mem0 asks for both speakers, says
"when in doubt, extract", sets a minimum count, and wants 15 to 80 words of context per
memory. Phase 7 is the place to test a mem0-style variant. Candidate changes:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Mark this section as written before phase 7 ran, or update it to the phase 7 results (not blocking).

This PR closes phase 7. The survey still says "Phase 7 is the place to test a mem0-style variant". Line 4 also places hotmemory at branch phase-6-accuracy-loop. roadmap.md now records that detail ran and that more prompts are deferred. A reader of the survey cannot tell which candidate changes detail already covers.

claude[bot]
claude Bot previously approved these changes Oct 15, 2026
@rohan-hotdata
rohan-hotdata merged commit 30ee45a into main Oct 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant