Repository navigation
ci: harden workflows against script injection - #222
Merged
Merged
Conversation
Pass inputs.bump, the App slug and the PR number to run steps through
env instead of interpolating ${{ }} into the shell script, which
Aikido flags as template injection (critical, cut-release.yml).
Also set persist-credentials explicitly on every checkout: false where
the job never pushes, true in cut-release where release.sh pushes the
release branch and tag.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves workflow inputs and step outputs out of
run:scripts into env vars (fixes Aikido critical template injection in cut-release.yml), and setspersist-credentialsexplicitly on every checkout.