Fix GHCommitPointer null repository path and add regression test#2265
Open
n09tal wants to merge 1 commit into
Open
Fix GHCommitPointer null repository path and add regression test#2265n09tal wants to merge 1 commit into
n09tal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #2035: handle null repository in GHCommitPointer#getCommit and add regression test.
What changed
src/main/java/org/kohsuke/github/GHCommitPointer.javagetCommit()to avoid an uncontrolled NullPointerException path.repositoryvariable fromgetRepository().IOException("Cannot commit because repository is null.").repository.getCommit(getSha()).src/test/java/org/kohsuke/github/GHCommitPointerTest.java(new file)nullRepoNpe.GHCommitPointerwith default null repository state.getCommit()now throwsIOException(not NPE)."repository is null".src/main/java/org/kohsuke/github/GHPullRequest.javagetHead()for debugging context.Why
Issue #2035 reports an NPE when
GHCommitPointer#getCommit()is called and repository data is missing.This change makes behavior explicit and controlled, and adds test coverage for the null-repository path.
Validation
mvn -Dtest=GHCommitPointerTest#nullRepoNpe testTests run: 1, Failures: 0, Errors: 0BUILD SUCCESS