Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a streamlined, production-ready developer workflow for the ROS 2 Vive Controller project. The main changes include the addition of a
.env-based configuration system, a newMakefilefor simplified Docker management, and significant improvements to the documentation for clarity and usability. The entrypoint script for CI environments has also been added. These changes make setup, deployment, and hardware mapping much easier and more robust.Developer Workflow & Configuration
.env.templatefile to standardize configuration of Steam credentials, ROS domain ID, scaling factors, and hardware serials; users now copy and edit.envfor their setup.Makefilenow automates all Docker build, run, and utility commands (e.g., build, pull, calibrate, identify, stop, clean), sourcing.envvariables and providing robot-specific targets for deployment.Documentation Improvements
README.mdto reflect the new workflow: clarified prerequisites, added step-by-step configuration and deployment instructions, documented the newMakefilecommands, and improved explanations of the driver node, TF tree, and hardware mapping.Continuous Integration
.ci/entrypoint.shto ensure ROS and workspace environments are sourced correctly in CI/CD and Docker environments.