[examples] Fix LR scheduler step count when num_train_epochs is set - #14743
Open
adi-IL wants to merge 1 commit into
Open
[examples] Fix LR scheduler step count when num_train_epochs is set#14743adi-IL wants to merge 1 commit into
adi-IL wants to merge 1 commit into
Conversation
…stently Same fix across training examples where num_train_epochs under-counted scheduler steps, especially in distributed runs. Supersedes huggingface#14527 huggingface#14528 huggingface#14540 huggingface#14546 huggingface#14597.
github-actions
Bot
added
size/M
This was referenced Sep 9, 2026
Contributor
|
Hi @adi-IL, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Please note that PRs without a linked issue are likely to be automatically closed 10 days after this notice. Once the PR links an issue (or gets the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8384
Why
Several example training scripts under-count LR scheduler steps when
num_train_epochsis used (especially distributed). That leaves the scheduler short of the intended schedule.Scope
One PR with the same fix across:
examples/text_to_image/train_text_to_image_sdxl.py(+ test)examples/text_to_image/train_text_to_image_lora_sdxl.py(+ test)examples/t2i_adapter/train_t2i_adapter_sdxl.py(+ test)examples/textual_inversion/textual_inversion.pyexamples/kandinsky2_2/text_to_image/train_text_to_image_prior.pyThis supersedes #14527, #14528, #14540, #14546, and #14597 so review can happen once.
Verification
main.Happy to split again if maintainers prefer per-example PRs.