Skip to content

[core] move pipeline-level model components to appropriate models. - #15187

Merged
sayakpaul merged 12 commits into
mainfrom
relocate-pipeline-models
Nov 19, 2026
Merged

sayakpaul merged 12 commits into
mainfrom
relocate-pipeline-models

Conversation

@sayakpaul

@sayakpaul sayakpaul commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Propagate the philosophy of #15111 throughout Diffusers.

Classification details below.

  • autoencoders now includes the ACE step tokenizer, LTX2 vocoder, SHAP-E renderer with the camera related stuff.
  • unets has the AudioLDM2 UNet.
  • condition_embedders has the Stable unCLIP normalizer.
  • Deprecate SHAP-E.
  • others for everything else where we cannot make a substantial difference and when the patterns aren't common enough. As discussed internally, we will deal with the rest of the elements through a combination of deprecation and remote elements.

@github-actions github-actions Bot added documentation Improvements or additions to documentation models tests modular-pipelines utils pipelines examples size/L PR with diff > 200 LOC labels Nov 5, 2026
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Nov 5, 2026 •

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul
sayakpaul marked this pull request as ready for review November 5, 2026 11:35
@sayakpaul
sayakpaul requested review from DN6 and yiyixuxu November 6, 2026 07:46
@github-actions github-actions Bot removed the documentation Improvements or additions to documentation label Nov 13, 2026


@dataclass
class DifferentiableProjectiveCamera:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh I think we can deprecate shap-e too, no?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just deprecated in the pipeline location, following what others are doing:
a647ae1

Follow-up PT will change the deprecation to use remote elements (will convert to remote) there in the PR.

LMK if you had in mind something else for deprecation.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh i meant we should deprecate the Shap-E pipeline itslef (can be a follow-up) -> but since we are deprecating it, we don't need to move its components right?

@sayakpaul

Copy link
Copy Markdown
Member Author

Failing tests are unrelated.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Nov 19, 2026
@sayakpaul
sayakpaul requested a review from yiyixuxu November 19, 2026 04:56

@yiyixuxu yiyixuxu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sayakpaul
sayakpaul merged commit d5df05e into main Nov 19, 2026
34 checks passed
@sayakpaul
sayakpaul deleted the relocate-pipeline-models branch November 19, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation examples models modular-pipelines pipelines size/L PR with diff > 200 LOC tests utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants