Skip to content

fix(modular): pass generator to scheduler.step in Flux and LTX denois… - #15358

Open
annm262002 wants to merge 1 commit into
huggingface:mainfrom
annm262002:fix/pass-generator-to-scheduler-step
Open

annm262002 wants to merge 1 commit into
huggingface:mainfrom
annm262002:fix/pass-generator-to-scheduler-step

Conversation

@annm262002

Copy link
Copy Markdown

…ing blocks (#15163)

FluxLoopAfterDenoiser, LTXLoopAfterDenoiser, and
LTXImage2VideoLoopAfterDenoiser called scheduler.step without forwarding the generator argument, so stochastic sampling (s_churn > 0) ignored the user-supplied seed and varied with global RNG across runs.

Add an inputs property declaring InputParam("generator") and a prepare_extra_kwargs helper (matching the pattern used by StableDiffusionXLLoopAfterDenoiser) to conditionally forward generator only when the active scheduler accepts it.

What does this PR do?

Fixes # (issue)

Before submitting

  • Did you use an AI agent (Claude Code, Codex, Cursor, etc.) to help with this PR? If so:
    • Did you read the Coding with AI agents guide?
    • Did you run the self-review skill on the diff?
    • Did you share the final self-review notes in the PR description or a comment?
  • Did you read the contributor guideline?
  • Did you read our philosophy doc? (important for complex PRs)
  • Was this discussed/approved via a GitHub issue or GitHub Discussions? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?
  • Are you the author (or part of the team we work with) of the model/pipeline this PR relates to?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

…ing blocks (huggingface#15163)

FluxLoopAfterDenoiser, LTXLoopAfterDenoiser, and
LTXImage2VideoLoopAfterDenoiser called scheduler.step without forwarding
the generator argument, so stochastic sampling (s_churn > 0) ignored the
user-supplied seed and varied with global RNG across runs.

Add an inputs property declaring InputParam("generator") and a
prepare_extra_kwargs helper (matching the pattern used by
StableDiffusionXLLoopAfterDenoiser) to conditionally forward generator
only when the active scheduler accepts it.
@github-actions github-actions Bot added modular-pipelines size/S PR with diff < 50 LOC labels Nov 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi @annm262002, thanks for the PR! It does not appear to link an issue it fixes.

  • If this PR addresses an existing issue, please add a closing keyword (e.g. Fixes #1234) to the PR description so the issue is linked.
  • If you are the author of the model/pipeline this PR relates to, or part of the team we work with on it, tick the Are you the author (or part of the team we work with) of the model/pipeline this PR relates to? box in the PR description (if you removed the template, paste that line back, checked). This reminder then no longer applies.
  • Otherwise there is nothing you need to do: a maintainer will look at the PR and add the no-issue-needed label to silence this reminder if it should stay open without an issue.

See the contribution guide for more details.

Please note that PRs without a linked issue are likely to be automatically closed 10 days after this notice.

Once the PR links an existing issue, the author box is ticked, or the no-issue-needed label is added, you can ignore this message — it stays here as a comment, but it no longer applies.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

modular-pipelines size/S PR with diff < 50 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant