Repository navigation
fix(modular): pass generator to scheduler.step in Flux and LTX denois… - #15358
Open
annm262002 wants to merge 1 commit into
Open
annm262002 wants to merge 1 commit into
annm262002 wants to merge 1 commit into
Conversation
…ing blocks (huggingface#15163) FluxLoopAfterDenoiser, LTXLoopAfterDenoiser, and LTXImage2VideoLoopAfterDenoiser called scheduler.step without forwarding the generator argument, so stochastic sampling (s_churn > 0) ignored the user-supplied seed and varied with global RNG across runs. Add an inputs property declaring InputParam("generator") and a prepare_extra_kwargs helper (matching the pattern used by StableDiffusionXLLoopAfterDenoiser) to conditionally forward generator only when the active scheduler accepts it.
Contributor
|
Hi @annm262002, thanks for the PR! It does not appear to link an issue it fixes.
See the contribution guide for more details. Please note that PRs without a linked issue are likely to be automatically closed 10 days after this notice. Once the PR links an existing issue, the author box is ticked, or the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing blocks (#15163)
FluxLoopAfterDenoiser, LTXLoopAfterDenoiser, and
LTXImage2VideoLoopAfterDenoiser called scheduler.step without forwarding the generator argument, so stochastic sampling (s_churn > 0) ignored the user-supplied seed and varied with global RNG across runs.
Add an inputs property declaring InputParam("generator") and a prepare_extra_kwargs helper (matching the pattern used by StableDiffusionXLLoopAfterDenoiser) to conditionally forward generator only when the active scheduler accepts it.
What does this PR do?
Fixes # (issue)
Before submitting
self-reviewskill on the diff?documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.