Repository navigation
ci: fix pr autoclose. - #15361
Open
sayakpaul wants to merge 1 commit into
Open
ci: fix pr autoclose.#15361sayakpaul wants to merge 1 commit into
sayakpaul wants to merge 1 commit into
Conversation
Collaborator
|
oh do you mean #15199 ? the bot worked as designed in this case through: the contributor opened the issue and linked to the PR themselves after seeing the bot reminder, so it does not count as linking an existing issue (I added that in this PR #15179 ) IMO we should not change that:
I think the reminder message already has the correct info #15199 (comment): it says the link to an "existing issue" and does not say to open one, but maybe can make it even clear the auto close message needs to be updated #15199 (comment) what do you think? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1521 (amongst others) was closed despite linking to an issue thread. This PR fixes that behaviour.