Skip to content

ci: fix pr autoclose. - #15361

Open
sayakpaul wants to merge 1 commit into
mainfrom
fix-pr-autoclosure
Open

sayakpaul wants to merge 1 commit into
mainfrom
fix-pr-autoclosure

Conversation

@sayakpaul

Copy link
Copy Markdown
Member

#1521 (amongst others) was closed despite linking to an issue thread. This PR fixes that behaviour.

@github-actions github-actions Bot added the size/S PR with diff < 50 LOC label Nov 20, 2026
@sayakpaul
sayakpaul requested a review from yiyixuxu November 20, 2026 11:52
@yiyixuxu

yiyixuxu commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

oh do you mean #15199 ?
i added no-issue-needed label on so it won't get closed again

the bot worked as designed in this case through: the contributor opened the issue and linked to the PR themselves after seeing the bot reminder, so it does not count as linking an existing issue (I added that in this PR #15179 )

IMO we should not change that:

  • we want to encourage issue + discussion first
  • its really easy to open an issue and add Fix # so counting that basically makes whole process pointless: our bot won't be able to close anything and we end up with a lot more meaningless issue
  • we can rescue a PR by adding the no-issue-needed label, feel free to add one as long as you are not 100% sure it should be closed

I think the reminder message already has the correct info #15199 (comment): it says the link to an "existing issue" and does not say to open one, but maybe can make it even clear

the auto close message needs to be updated #15199 (comment)

what do you think?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S PR with diff < 50 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants