Repository navigation
Conversation
Move the autoencoder, condition embedder, modular pipeline, docs and tests to the p_image_oss name. Keep the old p_h3_image modules as deprecated aliases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yiyixuxu
reviewed
Nov 20, 2026
| posterior = self.encode(sample).latent_dist | ||
| z = posterior.sample(generator=generator) if sample_posterior else posterior.mode() | ||
| return self.decode(z, return_dict=return_dict) | ||
| from .autoencoder_kl_p_image_oss import AutoencoderKLPH3Image, AutoencoderKLPImageOSS # noqa: F401 |
Collaborator
There was a problem hiding this comment.
can you deprecate the old names? let's do a really short one 0.45.0 so we can remove it then
https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipelines/ace_step/modeling_ace_step.py#L29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the autoencoder, condition embedder, modular pipeline, docs and tests to the p_image_oss name. Keep the old p_h3_image modules as deprecated aliases.
What does this PR do?
Renames the P-H3-Image model to P-Image-OSS across diffusers. The model code doesn't change.
AutoencoderKLPH3ImageAutoencoderKLPImageOSSPH3ImageTextConnectorPImageOSSTextConnectorPH3ImageBlocksPImageOSSBlocksPH3ImageModularPipelinePImageOSSModularPipelinemodular_pipelines/p_h3_image/modular_pipelines/p_image_oss/p-h3-imagep-image-ossDocs pages and tests are moved to the new names too.
autoencoder_kl_p_h3_image,condition_embedder_p_h3_image,modular_pipelines.p_h3_image) re-export from the new modules.p-h3-imagemodel type still maps toPImageOSSModularPipeline, so existing checkpoints keep loading._redirects.yml).Let me know if i should apply any other good practice to break as less as possible for users :)
Before submitting
self-reviewskill on the diff?documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.