Skip to content

fix : Rename to P-Image-OSS - #15362

Open
sdiazlor wants to merge 3 commits into
huggingface:mainfrom
sdiazlor:rename-p-h3-image-to-p-image-oss
Open

sdiazlor wants to merge 3 commits into
huggingface:mainfrom
sdiazlor:rename-p-h3-image-to-p-image-oss

Conversation

@sdiazlor

Copy link
Copy Markdown

Move the autoencoder, condition embedder, modular pipeline, docs and tests to the p_image_oss name. Keep the old p_h3_image modules as deprecated aliases.

What does this PR do?

Renames the P-H3-Image model to P-Image-OSS across diffusers. The model code doesn't change.

Old New
AutoencoderKLPH3Image AutoencoderKLPImageOSS
PH3ImageTextConnector PImageOSSTextConnector
PH3ImageBlocks PImageOSSBlocks
PH3ImageModularPipeline PImageOSSModularPipeline
modular_pipelines/p_h3_image/ modular_pipelines/p_image_oss/
model type p-h3-image p-image-oss

Docs pages and tests are moved to the new names too.

  • The old class names are kept as aliases of the new classes.
  • The old module paths (autoencoder_kl_p_h3_image, condition_embedder_p_h3_image, modular_pipelines.p_h3_image) re-export from the new modules.
  • The p-h3-image model type still maps to PImageOSSModularPipeline, so existing checkpoints keep loading.
  • The old docs URLs redirect to the new pages (_redirects.yml).

Let me know if i should apply any other good practice to break as less as possible for users :)

Before submitting

  • Did you use an AI agent (Claude Code, Codex, Cursor, etc.) to help with this PR? If so:
    • Did you read the Coding with AI agents guide?
    • Did you run the self-review skill on the diff?
    • Did you share the final self-review notes in the PR description or a comment?
  • Did you read the contributor guideline?
  • Did you read our philosophy doc? (important for complex PRs)
  • Was this discussed/approved via a GitHub issue or GitHub Discussions? Please add a link to it if that's the case. Discussed on Slack.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?
  • Are you the author (or part of the team we work with) of the model/pipeline this PR relates to?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Move the autoencoder, condition embedder, modular pipeline,
docs and tests to the p_image_oss name. Keep the old
p_h3_image modules as deprecated aliases.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added documentation Improvements or additions to documentation models tests modular-pipelines utils size/L PR with diff > 200 LOC labels Nov 20, 2026
posterior = self.encode(sample).latent_dist
z = posterior.sample(generator=generator) if sample_posterior else posterior.mode()
return self.decode(z, return_dict=return_dict)
from .autoencoder_kl_p_image_oss import AutoencoderKLPH3Image, AutoencoderKLPImageOSS # noqa: F401

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you deprecate the old names? let's do a really short one 0.45.0 so we can remove it then
https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipelines/ace_step/modeling_ace_step.py#L29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation models modular-pipelines size/L PR with diff > 200 LOC tests utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants