Fix false-positive escaping warning on get_block_wrapper_attributes#340
Merged
Conversation
rmccue
approved these changes
Jun 23, 2026
rmccue
left a comment
rmccue
left a comment
Member
There was a problem hiding this comment.
👍 Looks right based on the core implementation - which itself doesn't actually echo anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_block_wrapper_attributes responsibly builds its output string using safecss_filter_attr and esc_attr, and its output is not filterable. We should allow this function.
(This is particularly annoying to get false-flagged today, because it usually occurs within an inline tag in HTML partials that makes it visually clunky to add an ignore directive.)