Skip to content

framework: fix ws error logging - #1198

Merged
undefined-moe merged 1 commit into
hydro-dev:masterfrom
renbaoshuo:fix-ws-err
Aug 17, 2026
Merged

framework: fix ws error logging#1198
undefined-moe merged 1 commit into
hydro-dev:masterfrom
renbaoshuo:fix-ws-err

Conversation

@renbaoshuo

@renbaoshuo renbaoshuo commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved WebSocket error logging to record the actual message-processing error, making diagnostics more accurate.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f197cf56-6ce9-4001-8489-a6ffcc635324

📥 Commits

Reviewing files that changed from the base of the PR and between cf06238 and ca2479a.

📒 Files selected for processing (1)
  • framework/framework/server.ts

Included review availability: Your plan includes up to 8 reviews per rolling hour; 7 remain after this review.


Walkthrough

The WebSocket message handler now logs the caught message-processing error through err instead of the outer event variable e. No public declarations changed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ca247

This is a small, localized logging change with no actionable merge-blocking risk remaining; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the WebSocket error logging fix in the framework.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

framework/framework/server.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@undefined-moe
undefined-moe merged commit df00fa0 into hydro-dev:master Aug 17, 2026
5 of 6 checks passed
@renbaoshuo
renbaoshuo deleted the fix-ws-err branch August 17, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants