fix(http1): reject forbidden trailer fields - #4161
Open
freedom-winds wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a static audit of the HTTP/1 chunked-body decoding path, I found that decode_trailers() accepted every syntactically valid trailer field and inserted it directly into the trailer HeaderMap.
Specifically, a chunked request or response could include Content-Length, Transfer-Encoding, or Trailer in its trailer block. The previous implementation exposed these fields tothe application layer even though they must not be accepted as trailer fields b ecause they control or describe message framing.
The fix validates each trailer field name before inserting it into the HeaderMap. Content-Length, Transfer-Encoding, and Trailer now cause decoding to fail with
io::ErrorKind::InvalidInput.A regression test was added to verify that all three fields are rejected.