Fix CI caching and parameterize workflows by arch for future aarch64#1597
Open
ludfjig wants to merge 1 commit into
Open
Fix CI caching and parameterize workflows by arch for future aarch64#1597ludfjig wants to merge 1 commit into
ludfjig wants to merge 1 commit into
Conversation
ludfjig
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
simongdavies,
squillace and
syntactically
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Hyperlight’s GitHub Actions CI workflows to make runner selection and caching arch-aware (X64 vs arm64) and to clarify runner pool selection by CPU vendor, laying groundwork for future aarch64 expansion while reducing cache collisions.
Changes:
- Renames workflow/matrix parameter
cpu→cpu_vendorand threads it through reusable workflows and benchmark artifacts. - Parameterizes CI caching and runner labels by
arch(including priming caches for arm64). - Splits fuzzing targets into a matrix so each fuzz target runs as a separate job invocation.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Justfile | Renames bench-download parameter to cpu_vendor and updates artifact naming. |
| docs/benchmarking-hyperlight.md | Updates benchmark download instructions to match cpu_vendor. |
| .github/workflows/ValidatePullRequest.yml | Switches matrices to cpu_vendor and passes arch/cpu_vendor into reusable workflows. |
| .github/workflows/RustNightly.yml | Renames nightly matrix variable to cpu_vendor for pool selection. |
| .github/workflows/PrimeCaches.yml | Primes guest caches across architectures and makes host cache keys arch-aware. |
| .github/workflows/Fuzzing.yml | Converts fuzz targets from a JSON list input into a target matrix. |
| .github/workflows/dep_run_examples.yml | Updates inputs and runner selection to use cpu_vendor and handle non-X64 via an arch conditional. |
| .github/workflows/dep_fuzzing.yml | Updates inputs to single target/arch (but currently has a runner JSON construction bug). |
| .github/workflows/dep_build_test.yml | Updates inputs and runner selection to use cpu_vendor and handle non-X64 via an arch conditional. |
| .github/workflows/dep_build_guests.yml | Makes guest caches arch-aware (but currently has a runner JSON construction bug). |
| .github/workflows/dep_benchmarks.yml | Adds arch input, makes cache/artifact naming arch-aware, and switches to cpu_vendor. |
| .github/workflows/DailyBenchmarks.yml | Passes arch/cpu_vendor into reusable benchmarks workflow. |
| .github/workflows/CreateRelease.yml | Passes arch/cpu_vendor into reusable benchmarks workflow. |
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
force-pushed
the
ci/fix-fuzzing-and-cache-keys
branch
from
b88a2b7 to
dcb8e34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caching is broken so fixed it. Refactored some other stuff to easier add aarch64 support