-
Notifications
You must be signed in to change notification settings - Fork 187
update PR validation and daily runs to reduce PR dependance on ARM64 runners #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
simongdavies
merged 3 commits into
hyperlight-dev:main
from
simongdavies:trim-pr-validation-on-aarch64
Jun 30, 2026
+135
−22
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| # yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json | ||
|
|
||
| name: Daily aarch64 | ||
|
|
||
| # Full aarch64 coverage runs here on a schedule rather than on every PR, because | ||
| # there are only limited aarch64 runners. PRs run a reduced aarch64 | ||
| # build-test (build + default Rust tests only) and skip aarch64 examples; this | ||
| # workflow restores Miri, the single-driver tests, and the examples once a day. | ||
|
|
||
| on: | ||
| schedule: | ||
| - cron: '0 5 * * *' # Runs at 05:00 UTC every day | ||
| workflow_dispatch: # Allow manual triggering | ||
|
|
||
| env: | ||
| CARGO_TERM_COLOR: always | ||
| RUST_BACKTRACE: full | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
||
| jobs: | ||
| # Build aarch64 guest binaries once and upload them as artifacts for the | ||
| # build-test and run-examples jobs to download. | ||
| build-guests: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| config: [debug, release] | ||
| uses: ./.github/workflows/dep_build_guests.yml | ||
| secrets: inherit | ||
| with: | ||
| arch: arm64 | ||
| config: ${{ matrix.config }} | ||
|
|
||
| # Full aarch64 build-and-test. full_aarch64: "true" re-enables the Miri and | ||
| # single-driver steps that are skipped on PRs. | ||
| build-test: | ||
| needs: build-guests | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| config: [debug, release] | ||
| uses: ./.github/workflows/dep_build_test.yml | ||
| secrets: inherit | ||
| with: | ||
| hypervisor: kvm | ||
| cpu_vendor: apple | ||
| arch: arm64 | ||
| config: ${{ matrix.config }} | ||
| full_aarch64: "true" | ||
|
|
||
| run-examples: | ||
| needs: build-guests | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| config: [debug, release] | ||
| uses: ./.github/workflows/dep_run_examples.yml | ||
| secrets: inherit | ||
| with: | ||
| hypervisor: kvm | ||
| cpu_vendor: apple | ||
| arch: arm64 | ||
| config: ${{ matrix.config }} | ||
|
|
||
| # Fuzz on aarch64. This coverage was removed from PRs in #1594 to conserve the | ||
| # limited arm64 runners, and runs here daily instead. The tracing | ||
| # fuzzers (fuzz_guest_trace, fuzz_guest_estimate_trace_event) are x86_64-only | ||
| fuzzing: | ||
| needs: build-guests | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| target: ['fuzz_host_print', 'fuzz_guest_call', 'fuzz_host_call'] | ||
| uses: ./.github/workflows/dep_fuzzing.yml | ||
| secrets: inherit | ||
| with: | ||
| target: ${{ matrix.target }} | ||
| arch: arm64 | ||
| max_total_time: 300 # 5 minutes in seconds | ||
|
|
||
| # File (or update) a release-blocking GitHub issue if any job fails. The first | ||
| # label (area/ci-periodics-aarch64) is the de-duplication key used by | ||
| # notify-ci-failure.sh, so this workflow maintains its own issue lineage and is | ||
| # guaranteed to carry release-blocker, instead of commenting on another periodic | ||
| # job's issue. NOTE: that label must exist in the repo (Issues -> Labels) or the | ||
| # `gh issue create` call will fail. | ||
| notify-failure: | ||
| runs-on: ubuntu-latest | ||
| needs: [build-guests, build-test, run-examples, fuzzing] | ||
| if: always() && (needs.build-guests.result == 'failure' || needs.build-test.result == 'failure' || needs.run-examples.result == 'failure' || needs.fuzzing.result == 'failure') | ||
|
simongdavies marked this conversation as resolved.
|
||
| permissions: | ||
| # Job-level permissions replace (not merge with) the workflow-level grant, | ||
| # so contents:read must be re-declared for actions/checkout to work. | ||
| contents: read | ||
| issues: write | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
|
|
||
| - name: Notify Daily aarch64 Failure | ||
| run: ./dev/notify-ci-failure.sh --title="Daily aarch64 Failure - ${{ github.run_number }}" --labels="area/ci-periodics-aarch64,area/ci-periodics,area/testing,lifecycle/needs-review,release-blocker" | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.