Repository navigation
ci: give dtolnay/rust-toolchain a valid toolchain input - #219
Conversation
dtolnay/rust-toolchain at @v1 (and at its master-branch commits) declares `toolchain` as required with no default; only the toolchain-named branches such as @stable supply one. Steps here either: - set no `toolchain:` at all, so the action fails with "'toolchain' is a required input"; - set an invalid value (v1, master, or a note), which rustup cannot install; or - carry a second `with:` key injected above the real one by an earlier bulk edit. A duplicate key makes GitHub reject the whole workflow file. Each affected step now has exactly one `with:` with a valid toolchain: an injected toolchain-only `with:` block is dropped, an invalid value becomes `stable`, and a step with none gets `toolchain: stable`. An existing valid value ('1.97.0', ${{ env.RUST_VERSION }}, stable) is kept as is. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0132Cdz3iwk2QGKv2sUhhsye
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Add Carrot credits or activate Agent usage billing to use Autofix |
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
2 participants
What was wrong
dtolnay/rust-toolchain@v1declarestoolchainas required with no default (only branches like@stablesupply one). Affected steps either set none ('toolchain' is a required input), set an invalid value (v1), or carry a secondwith:key injected above the real one by an earlier bulk edit. A duplicate key makes GitHub reject the whole workflow file.Changes
Each affected step now has exactly one
with:and a valid toolchain.cargo-audit.yml,coverage.yml,release.yml: drop the injected duplicatewith:/toolchain: v1(the realtoolchain: stablestays).e2e.yml:v1→stableon one step; addtoolchain: stableto three others.chapel-ci.yml:v1→stableon one step; add it to another.Not fixed here
cargo-audit.yml,chapel-ci.yml,coverage.yml,e2e.ymlandrelease.ymlare also blocked by olderactions.lockmismatches (actions bumped without regenerating the lock). GitHub won't start them until the lock is regenerated; that is separate and unchanged.Testing
YAML parses; standards'
check-lock-sync.shreports no new failures.Generated by Claude Code