Repository navigation
fix(deps): lockfile bumps clearing the fixable RustSec advisories - #222
Closed
hyperpolymath wants to merge 21 commits into
Closed
hyperpolymath wants to merge 21 commits into
hyperpolymath wants to merge 21 commits into
Conversation
docs/ambush-timeline.md and docs/panll-export.md were converted to .adoc (estate docs policy) but the self-diagnostics check still demanded the .md files, so `panic-attack diagnostics` exited non-zero and both diagnostics readiness tests failed. Point the check, README.adoc and the bridge module docs at the .adoc files that exist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
…istener, wayland-scanner Lockfile-only, semver-compatible updates clearing RUSTSEC-2026-0204 (crossbeam-epoch), -0346/0347/0348/0349 (rustls 0.23.46), -0257 (webbrowser), the event-listener and memmap2 unsound notices, and moving wayland-scanner onto quick-xml 0.41. quick-xml 0.38 remains only via zbus_xml 5 under accesskit (eframe's GUI feature); no released accesskit or atspi-common moves off it yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
…on-th4e9w-readiness
…ssion-th4e9w-audit
…on-th4e9w-readiness
…ssion-th4e9w-audit
Contributor
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyperpolymath
marked this pull request as ready for review
October 19, 2026 18:43
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
hyperpolymath
added this pull request to stack #224
October 19, 2026 20:48
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
|
Add Carrot credits or activate Agent usage billing to use Autofix |
…ssion-th4e9w-audit
…on-th4e9w-readiness
…ick-xml 0.38 zbus_xml 5.2.1 builds on quick-xml 0.41, so the last copy of quick-xml 0.38.4 (RUSTSEC-2026-0194, RUSTSEC-2026-0195) leaves the lockfile. Lockfile only; semver-compatible: zbus_names 4.3.5, zbus_xml 5.2.1, zvariant 5.15.1, zvariant_derive 5.15.1, plus their new transitive deps winnow 1.0.4, zcheapstr 1.1.0, zvariant_utils 4.2.0. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
…'s lockfile (its bumps include CodeRabbit's quick-xml 0.41 move) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
…erge left two unused CodeRabbit's hunk added an all_chars_safe helper beside this branch's is_safe_char, and the merge kept both with neither caller, which cargo clippy --all-targets -- -D warnings rejects as dead code in the lib test target. The file is the version CI passed at 5db5d90. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
…ess' into claude/new-session-th4e9w-audit
…ssion-th4e9w-audit
…ries (#231) Stacked on #222 (← #221 ← #220 ← #218). ## What Lockfile-only bump of `zbus_xml` 5.1.0 → 5.2.1. This removes the last `quick-xml 0.38.4` from `Cargo.lock` and clears: - RUSTSEC-2026-0194: quadratic attribute checking in quick-xml - RUSTSEC-2026-0195: unbounded namespace allocation in quick-xml ## Why no upstream PR or `[patch]` is needed The handoff plan assumed every `zbus_xml` 5.x release still used `quick-xml ^0.38`. crates.io shows otherwise: | zbus_xml | XML parser | |---|---| | 5.1.0 (was locked) | quick-xml ^0.38 | | 5.1.1 | quick-xml ^0.39 | | 5.2.0, 5.2.1 | winnow ^1.0 (no quick-xml) | `zbus-lockstep 0.5.2` (via `atspi-common 0.13`) requires `zbus_xml ^5.0.2`, so 5.2.1 is a semver-compatible resolution. The fix is already published upstream; the lockfile simply had not picked it up. ## Side effects in the lockfile All behind the opt-in `gui` feature. Default builds are unchanged. - `zvariant` / `zvariant_derive` 5.10.0 → 5.15.1 - `zbus_names` 4.3.1 → 4.3.5 - adds `winnow 1.0.4`, `zvariant_utils 4.2.0`, `zcheapstr 1.1.0`, `syn 3.0.3` (proc-macro only) Every new crate declares `rust-version` ≤ 1.87, the floor the previously locked `zvariant 5.10.0` already set. The `gui` MSRV does not move. ## Verification (local, Rust 1.99.0) - `cargo audit`: before, 2 vulnerabilities, exit 1. After, 0 vulnerabilities, exit 0, with zero ignores and no `audit.toml`. - The same five `unmaintained` warnings appear before and after: ttf-parser, unsafe-libyaml, zbus_names, zvariant, zvariant_derive. - `cargo check --all-features --all-targets`: pass - `cargo clippy --all-features --all-targets -- -D warnings`: pass - `cargo test --all-features`: all suites pass ## Follow-up (not in this PR) `zvariant`, `zvariant_derive` and `zbus_names` gained `unmaintained` notices on 2026-10-16 because they were folded into zbus 6. These are warnings, not failures. They clear only when accesskit/atspi move to zbus 6. --- _Generated by [Claude Code](https://claude.ai/code/session_01Jma5ixtpeZyJRmfoSsC98u)_ Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Oct 20, 2026
Owner
Author
|
Superseded by the flattened direct-to-main PR #233. Its combined tree is preserved there, and the full PR CI suite has passed; closing this stacked child avoids the base-branch restriction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #221, which sits on #220 and #218. This is the Cargo Audit follow-up from #218 (comment).
Change (
Cargo.lockonly, semver-compatible)quick-xml 0.38.4 (RUSTSEC-2026-0194, -0195): cleared
Earlier revisions of this PR said no released crate moved off
zbus_xml5 and the two quick-xml advisories would keep failing.zbus_xml5.2.1 builds on quick-xml 0.41, so the 0.38 copy is gone from the lockfile (commit cb067e2, the one lockfile bump CodeRabbit's 0f68c62 on #218 also made). Whatcargo auditstill prints are unmaintained-crate warnings (ttf-parser, unsafe-libyaml, zbus_names, zvariant*), which do not fail the job.Verification
cargo check --locked(no warnings),cargo fmt --check,cargo clippy --lockedclean andcargo test --lockedgreen on the stack top (chore(k9): retire the k9iser output and manifest #223).Cargo.lockholds a singlequick-xmlentry, 0.41.0.Generated by Claude Code