Repository navigation
fix(ci): semantic-audit-check fails closed instead of printing a pass - #53
Conversation
…pass The action echoed a list of checks and then "Semantic Audit Passed" unconditionally. It called nothing; the cicd-squabbler `audit` subcommand it names does not exist. No workflow calls it yet, but the first caller would have gained a gate that cannot fail. It now exits 1 with an explicit not-implemented error until a real audit exists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015bTuGfwCcvjrmNFejydTML
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (6)
🔇 Additional comments (1)
📝 SummarySummary by CodeRabbit
WalkthroughThe semantic audit composite action now identifies itself as unimplemented, prints an error, and exits with status 1 instead of reporting a pass. ChangesSemantic audit gate
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The unimplemented audit no longer reports a pass. No actionable merge blocker remains from the supplied evidence. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit reads the gate’s new sign, Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
.github/actions/semantic-audit-check/action.ymlprinted a list of checks and thenSemantic Audit Passedunconditionally. It checked nothing. The cicd-squabbleraudit --semanticsubcommand it names does not exist. It now fails closed: one step emits::error title=semantic-audit-check::not implemented …andexit 1.No workflow in this repo calls the action today (
git grep semantic-audit-check origin/main -- .githubmatches only the action itself), so nothing goes red. But the first caller would have gained a gate that cannot fail. Same placeholder in 7 repos; same fix in each. Owner decision (2026-10-07): fail closed here, and do the real squabbling centrally from cicd-squabbler once it ships a pinned artifact. It has none today: no release, no tag, no container package.Type of change
📌 New pins
Head SHA: 431d46a. No pins added or changed: no
uses:,actions.lock, lockfile or digest is touched.How has this been verified?
yq -o=json . .github/actions/semantic-audit-check/action.ymlparses (KYAML content, D280; filename kept because Actions requiresaction.yml).git diff --stat origin/main: exactly 1 file changed.git grep -l semantic-audit-check origin/main -- .githublists no workflow.%G?= G).Checklist
git commit -S).SPDX-License-Identifier: not ticked. There are no new files; the modified file had no SPDX header before, and adding one is a licence edit left to the owner.Notes for reviewers
A failing step is the intended behaviour. Wire this action into a workflow only once a real audit exists.
🤖 Generated with Claude Code
https://claude.ai/code/session_015bTuGfwCcvjrmNFejydTML