Repository navigation
fix: final review of 5.3.0 before tagging - #135
Merged
Merged
Conversation
Test comments now describe the reported problem without naming the person who reported it, and example paths use /Users/alex/ and C:\Users\Alex\. No assertion changes.
…ad of stopping the Move Two files of one batch that the naming convention gives the same name in the same folder (two exports of one day) made Organize refuse the whole run. The second and later files now get main's numbered name (_1, _2), Preview marks them "Name taken — number added", and a file already at its destination keeps its name. A refused batch (another run in progress, too large) now shows main's reason instead of "Check the logs" and no longer lists every file as interrupted. A card whose folder the user changed no longer shows a confidence score for it.
…shared folder-name words do not pick a folder
dropPromptEchoes no longer checks the reasoning against Smart Folder
descriptions (the prompt asks the model to cite them), and a word that
also occurs in the document no longer counts as copied from a description.
In matchCategoryToFolder's token-overlap step a word shared by two or more
folder names ("exports") no longer scores, and a tie falls through to the
description step instead of going to the first folder in the list.
…icon Mac is always Metal ModelMemoryManager budgeted 70% of os.freemem(), which on macOS counts only free pages, so without a VRAM figure a busy Mac got a budget of a few hundred MB and evicted models between files. It now uses the shared available-memory reading (unchanged on Windows and Linux). GPUMonitor returns Metal with unified memory on darwin/arm64 even when system_profiler fails or times out.
…ing and the documented Zed config Finder instead of Explorer on a Mac; the Uncategorized access warning names the right OS setting; MCP copy confirmations name the app; the Advanced settings text drops "Save to apply"; Memory & Rules and the User Guide no longer say a typed rule applies to every file of that type; the Zed snippet drops the undocumented source key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final review of 5.3.0 before it is tagged. A four-way review of
main(Mac paths, the retest walk-through, the open task acceptance criteria, and a bug review of everything merged since 5.2.0) found these. Each fix has a unit test that fails without it.Fixes
_1,_2); Preview marks "Name taken — number added"; a file already in place keeps its name.analysisLabel; main recordsdivergence?.oldCategory || analysisLabel. Schema accepts the optional field.reasoningis no longer checked against folder descriptions; words also in the document do not count as copied. Schema-instruction echoes still caught.os.freemem()(free pages only), so without a VRAM figure a busy Mac budgeted a few hundred MB and evicted models between files.system_profilerfails.claudeDesktopid in a toast; Advanced text said "Save to apply"."source": "http"key.Also: test comments and fixture paths no longer name an individual tester; CHANGELOG 5.3.0 lists the fixes above.
PR #133 (macOS CI test fix) is already merged; the review confirmed the macOS failure was the test, not the app.
Checks (local, Windows 11 x64, Node 24.22.2)
Full
npm run cichain: format, lint, typecheck, typecheck:js, both audits, compliance (inventory unchanged),test:coverage— 1,013 suites, 14,792 passed, 11 skipped; coverage statements 76.6 / branches 65.67 / functions 76.62 / lines 78.15 — every verify step, knip and build.Not verifiable here
The Mac memory and Finder wording need a real Mac; they are covered by unit tests with the platform mocked.