Skip to content

fix: final review of 5.3.0 before tagging - #135

Merged
iLevyTate merged 6 commits into
mainfrom
fix/v5.3.0-final-review
Nov 14, 2026
Merged

iLevyTate merged 6 commits into
mainfrom
fix/v5.3.0-final-review

Conversation

@iLevyTate

Copy link
Copy Markdown
Owner

Final review of 5.3.0 before it is tagged. A four-way review of main (Mac paths, the retest walk-through, the open task acceptance criteria, and a bug review of everything merged since 5.2.0) found these. Each fix has a unit test that fails without it.

Fixes

Problem Fix
P1 Two files of one batch given the same new name (two exports of one day) made Organize refuse the whole Move. Renderer numbers them apart in main's format (_1, _2); Preview marks "Name taken — number added"; a file already in place keeps its name.
P2 A correction where the AI label already named the right folder (but the ranking picked another) was stored without the label, so two such corrections never taught an override. Ops carry analysisLabel; main records divergence?.oldCategory || analysisLabel. Schema accepts the optional field.
P2 Short, accurate summaries/reasons using a folder description's words were treated as prompt echoes (fields erased, confidence capped at 50%). reasoning is no longer checked against folder descriptions; words also in the document do not count as copied. Schema-instruction echoes still caught.
P2 A label like "Google Search Console exports" matched every "… exports" folder on the shared word and went to whichever folder was added first. Words shared by 2+ folder names are ignored in the token-overlap step; ties fall through to descriptions.
P2 On macOS the model budget was 70% of os.freemem() (free pages only), so without a VRAM figure a busy Mac budgeted a few hundred MB and evicted models between files. Uses the shared available-memory reading (unchanged on Windows/Linux); darwin/arm64 is always Metal even when system_profiler fails.
P2 Memory & Rules and the User Guide said a typed rule "applies to every file of that type"; it only nudges folders already considered. Wording fixed (no behaviour change).
P3 A batch main refused outright said only "Check the logs" and listed every file as interrupted. Main's reason is shown in the summary and on each file.
P3 A card the user changed showed the AI label's confidence beside the user's folder. Hidden for user picks.
P3 Mac: "Explorer", "Windows Security", claudeDesktop id in a toast; Advanced text said "Save to apply". Platform wording, readable client names, text removed.
P3 Zed snippet had an undocumented "source": "http" key. Removed.

Also: test comments and fixture paths no longer name an individual tester; CHANGELOG 5.3.0 lists the fixes above.

PR #133 (macOS CI test fix) is already merged; the review confirmed the macOS failure was the test, not the app.

Checks (local, Windows 11 x64, Node 24.22.2)

Full npm run ci chain: format, lint, typecheck, typecheck:js, both audits, compliance (inventory unchanged), test:coverage — 1,013 suites, 14,792 passed, 11 skipped; coverage statements 76.6 / branches 65.67 / functions 76.62 / lines 78.15 — every verify step, knip and build.

Not verifiable here

The Mac memory and Finder wording need a real Mac; they are covered by unit tests with the platform mocked.

Test comments now describe the reported problem without naming the
person who reported it, and example paths use /Users/alex/ and
C:\Users\Alex\. No assertion changes.
…ad of stopping the Move

Two files of one batch that the naming convention gives the same name in
the same folder (two exports of one day) made Organize refuse the whole
run. The second and later files now get main's numbered name (_1, _2),
Preview marks them "Name taken — number added", and a file already at its
destination keeps its name. A refused batch (another run in progress, too
large) now shows main's reason instead of "Check the logs" and no longer
lists every file as interrupted. A card whose folder the user changed no
longer shows a confidence score for it.
…shared folder-name words do not pick a folder

dropPromptEchoes no longer checks the reasoning against Smart Folder
descriptions (the prompt asks the model to cite them), and a word that
also occurs in the document no longer counts as copied from a description.
In matchCategoryToFolder's token-overlap step a word shared by two or more
folder names ("exports") no longer scores, and a tie falls through to the
description step instead of going to the first folder in the list.
…icon Mac is always Metal

ModelMemoryManager budgeted 70% of os.freemem(), which on macOS counts only
free pages, so without a VRAM figure a busy Mac got a budget of a few
hundred MB and evicted models between files. It now uses the shared
available-memory reading (unchanged on Windows and Linux). GPUMonitor
returns Metal with unified memory on darwin/arm64 even when
system_profiler fails or times out.
…ing and the documented Zed config

Finder instead of Explorer on a Mac; the Uncategorized access warning
names the right OS setting; MCP copy confirmations name the app; the
Advanced settings text drops "Save to apply"; Memory & Rules and the User
Guide no longer say a typed rule applies to every file of that type; the
Zed snippet drops the undocumented source key.
@iLevyTate
iLevyTate merged commit 274b533 into main Nov 14, 2026
8 checks passed
@iLevyTate
iLevyTate deleted the fix/v5.3.0-final-review branch November 14, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant