Repository navigation
fix: code-scanning findings, two bug-hunt rounds and plain wording across the app - #138
Merged
Merged
Conversation
…erride, MCP auth and the preload stripper - Chat search escapes the LIKE escape character, so a query with a backslash (C:\Users) matches the real text. - ConfigurationManager.override refuses __proto__, constructor and prototype path segments. - The MCP bearer regex starts the token at a non-space, so a header of spaces cannot backtrack. - The preload HTML stripper repeats until stable and accepts closing tags with spaces or junk before '>'. - platform.js uses fixed separator regexes; in-memory dedup keys use sha256; the e2e orphan cleanup runs without a shell.
… and lifecycle Two bug hunts over the app plus a review of the first round's own fixes. Every fix comes with a test that fails on the old code. Highlights: - A full search rebuild interrupted by quitting no longer leaves an empty index marked as finished; the interrupted flag stays set for next launch. - Triage Organize waits for slow cross-drive moves instead of reporting them failed after 30 s while the file keeps moving. - Two empty files are no longer treated as duplicates. - Search spelling correction leaves real words alone and still searches the word as typed. - The startup learning scan keeps its own record of what it learned, so it no longer stops once feedback history fills up. - Go to Home after a screen error stops a running analysis. - Restoring the oldest settings backup keeps it; rotation still holds the limit and drops the oldest other backup instead. - Wrong-size or non-finite vectors fail only themselves, not the batch. - Model downloads, setup wizard, AI status, MCP port fallback and error messages, chat scope limit, smart folder rename of nested folders, macOS Unicode file names, case-only rename resume, and more.
…e positives Trash on network drives - Windows keeps no Recycle Bin on a share or a drive mapped to one, so TrashService now leaves those files in place with NETWORK_NO_RECYCLE_BIN instead of letting trashItem delete them permanently. realpath resolves a mapped drive to its share path. - Duplicate cleanup accepts share paths (still refusing admin shares, device paths and traversal) and reports which files were left on a network drive. Analysis runs - The stuck-run watchdog and Force reset used the Redux reset, which wiped every finished result and left the run lock held. Both now use the run reset, which keeps results and requeues unfinished files. Names - The fallback name keeps a compound archive extension (.tar.gz, .tar.xz) when given only its last part. Embeddings - After an embedding model change, queued vectors from the old model are dropped instead of being written into the new index. Quantizations of the same model still count as the same model. Search spelling correction - A word that occurs in the indexed files is never corrected, and a correction that occurs in the index is preferred. - A corrected search offers "Search for <original> instead". Code scanning - mac-release checks out the release tag ref and only restores the npm cache. - Script and style end tags match with attributes, HTML tag stripping repeats until stable, and the ffmpeg filter path escapes backslashes and colons. Housekeeping - Remove two unused constants from compose-walkthrough-media. - Give the three-service restore-worker parity test a 30 s timeout; it takes about 1.5 s alone but passed 10 s on a loaded machine.
- Remove em and en dashes from user-visible text in the renderer and in
main-process messages that reach the UI. Number and date ranges read
"X to Y". Lone placeholders for empty values stay.
- Drop "Please" from error and toast messages, and cut filler ("Ask me
anything", "streamlined", "with confidence"). Meaning, numbers and
feature names are unchanged.
- Point messages at Settings sections that exist: Model management for
downloads, Default AI models for picking a model, Local AI engine when
the engine is down, AI Provider for cloud providers. "Settings > Models",
"Settings > AI" and "Settings > Advanced" did not exist.
- Semantic IPC errors name the feature ("The search index isn't ready yet")
instead of internal service names.
- Text that code matches on ("Vector DB", "invalid characters", "Another
batch operation is already in progress") keeps those phrases.
- Log lines, prompts sent to the model, entity tables and code comments are
unchanged.
…form On Linux a Windows path is not absolute, so the settings sanitizer drops it and auto-recovery returned no defaultSmartFolderLocation. The app is right: Electron never reports a Windows path there. The mock now matches the platform, which fixes the ci (ubuntu-latest) failure on this branch.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four commits on top of v5.3.1: code-scanning fixes, two bug-hunt rounds, the follow-ups those left open, and a plain-wording pass over the app's text. Every behavior fix has a test that fails on the old code.
Security (code scanning)
C:\Users) matches the real text.ConfigurationManager.overriderefuses__proto__,constructorandprototypepath segments.>. Script and style end tags match with attributes.platform.jsuses fixed separator regexes, in-memory dedup keys use sha256, the e2e orphan cleanup runs without a shell, and the ffmpeg filter path escapes backslashes and colons.mac-releasechecks out the release tag ref and only restores the npm cache.Bugs
NETWORK_NO_RECYCLE_BIN) instead of being deleted permanently, since shares have no Recycle Bin..tar.gz,.tar.xz).Wording
Checks (local, Windows 11 x64, Node 24.22.2)
verify:*step innpm run ci, generate:channels:check, knip:files and build all pass.Notes for review
[Unreleased]is empty. Entries are needed before the next release.