Repository navigation
test(notebook): give the many-parts speed check room for a busy CI runner - #142
Merged
Merged
Conversation
…nner The check failed on macOS at 1,505 ms against a 1,500 ms limit, on main after the 5.4.0 merge. It guards against a quadratic join of 300,000 cell parts, not exact speed, so the limit is now 5 s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS job on main failed after the 5.4.0 merge (run 43982122763):
extractors.notebookExtractor.test.jsmeasured 1,505 ms against a 1,500 ms limit. The code and test are unchanged since the initial snapshot, and the same test passed on Ubuntu and Windows.The check guards against a quadratic join of 300,000 cell parts, not exact speed, so the limit is now 5 s. Test only; no app code changes.