Repository navigation
Fix panic when printing the help, version, or specification output fails - #174
Merged
Merged
Conversation
ia0
approved these changes
Oct 7, 2026
ia0
left a comment
Owner
There was a problem hiding this comment.
Thanks!
I've also made sure there's no silent errors when flushing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The help, version, and specification outputs are printed with
print!/println!, which panic when the write fails (for example with a broken pipe or a full disk) instead of returning a write error like the encode and decode modes do:This replaces those macros with
write!/writeln!onstd::io::stdout()so that write errors are reported like the other modes:Since all three outputs end with a newline, the line-buffered stdout flushes before
wrapped_mainreturns, so no flush error is dropped. Follows the pattern of #172.